Hi Linus, Please see my comments inline.
2015-12-09 22:34 GMT+09:00 Linus Walleij <[email protected]>: > This makes the driver use the data pointer added to the gpio_chip > to store a pointer to the state container instead of relying on > container_of(). > > Cc: Tomasz Figa <[email protected]> > Cc: Kukjin Kim <[email protected]> > Signed-off-by: Linus Walleij <[email protected]> > --- > drivers/pinctrl/samsung/pinctrl-exynos5440.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos5440.c > b/drivers/pinctrl/samsung/pinctrl-exynos5440.c > index f61f9a6fa9af..00ab63abf1d9 100644 > --- a/drivers/pinctrl/samsung/pinctrl-exynos5440.c > +++ b/drivers/pinctrl/samsung/pinctrl-exynos5440.c > @@ -15,7 +15,7 @@ > #include <linux/io.h> > #include <linux/slab.h> > #include <linux/err.h> > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> Commit message doesn't mention this change. Do I assume correctly that it's needed for gpiochip_get_data() and also gives the driver access to all definitions it needed from linux/gpio.h? Other than that (and the fact that, as opposed to the other Exynos patch, this one is actually cleaner): Acked-by: Tomasz Figa <[email protected]> Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
