On Tue 22 Dec 06:31 PST 2015, Linus Walleij wrote: > As we want gpio_chip .get() calls to be able to return negative > error codes and propagate to drivers, we need to go over all > drivers and make sure their return values are clamped to [0,1]. > We do this by using the ret = !!(val) design pattern. > > This code was also double-inverting a bool which makes no sense > so I removed that code and moved clamping toward the end. > > Cc: Björn Andersson <bjorn.anders...@sonymobile.com> > Signed-off-by: Linus Walleij <linus.wall...@linaro.org> > --- > drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c > b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c > index 8f5c96cbf94e..23089d541230 100644 > --- a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c > +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c > @@ -502,13 +502,13 @@ static int pm8xxx_mpp_get(struct gpio_chip *chip, > unsigned offset) > int ret; > > if (!pin->input) > - return pin->output_value; > + return !!pin->output_value;
Per my answer on the gpio driver, you have my Reviewed-by on this piece. > > ret = irq_get_irqchip_state(pin->irq, IRQCHIP_STATE_LINE_LEVEL, &state); > if (!ret) > - ret = !!state; > + ret = state; > > - return ret; > + return !!ret; But not on these two. Regards, Bjorn > } > > static void pm8xxx_mpp_set(struct gpio_chip *chip, unsigned offset, int > value) > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
