Send Linux-ha-cvs mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs
or, via email, send a message with subject or body 'help' to
[EMAIL PROTECTED]
You can reach the person managing the list at
[EMAIL PROTECTED]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Linux-ha-cvs digest..."
Today's Topics:
1. Linux-HA CVS: membership by lars from
([email protected])
2. Linux-HA CVS: membership by lars from
([email protected])
3. Linux-HA CVS: lib by lars from ([email protected])
4. Linux-HA CVS: lib by lars from ([email protected])
5. Linux-HA CVS: lib by lars from ([email protected])
----------------------------------------------------------------------
Message: 1
Date: Fri, 7 Apr 2006 07:15:13 -0600 (MDT)
From: [email protected]
Subject: [Linux-ha-cvs] Linux-HA CVS: membership by lars from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : lars
Host :
Project : linux-ha
Module : membership
Dir : linux-ha/membership/ccm
Modified Files:
ccmupdate.c
Log Message:
CID 15: signed vs unsigned ints.
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/membership/ccm/ccmupdate.c,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -3 -r1.20 -r1.21
--- ccmupdate.c 17 Feb 2006 05:48:24 -0000 1.20
+++ ccmupdate.c 7 Apr 2006 13:15:13 -0000 1.21
@@ -1,4 +1,4 @@
-/* $Id: ccmupdate.c,v 1.20 2006/02/17 05:48:24 zhenh Exp $ */
+/* $Id: ccmupdate.c,v 1.21 2006/04/07 13:15:13 lars Exp $ */
/*
* update.c: functions that track the votes during the voting protocol
*
@@ -246,7 +246,7 @@
static int
update_find_leader(ccm_update_t *tab, llm_info_t *llm)
{
- uint i, leader, j;
+ int i, leader, j;
for ( i = 0 ; i < llm_get_nodecount(llm); i++ ){
if (UPDATE_GET_INDEX(tab, i) != -1) {
------------------------------
Message: 2
Date: Fri, 7 Apr 2006 07:17:47 -0600 (MDT)
From: [email protected]
Subject: [Linux-ha-cvs] Linux-HA CVS: membership by lars from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : lars
Host :
Project : linux-ha
Module : membership
Dir : linux-ha/membership/ccm
Modified Files:
ccmupdate.c
Log Message:
CID 14: signed vs unsigned.
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/membership/ccm/ccmupdate.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -3 -r1.21 -r1.22
--- ccmupdate.c 7 Apr 2006 13:15:13 -0000 1.21
+++ ccmupdate.c 7 Apr 2006 13:17:47 -0000 1.22
@@ -1,4 +1,4 @@
-/* $Id: ccmupdate.c,v 1.21 2006/04/07 13:15:13 lars Exp $ */
+/* $Id: ccmupdate.c,v 1.22 2006/04/07 13:17:47 lars Exp $ */
/*
* update.c: functions that track the votes during the voting protocol
*
@@ -219,7 +219,7 @@
void
update_display(int pri,llm_info_t* llm, ccm_update_t* tab)
{
- unsigned i;
+ int i;
ccm_debug(pri, "diplaying update information: ");
ccm_debug(pri, "leader=%d(%s) nodeCount=%d",
------------------------------
Message: 3
Date: Fri, 7 Apr 2006 07:24:05 -0600 (MDT)
From: [email protected]
Subject: [Linux-ha-cvs] Linux-HA CVS: lib by lars from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : lars
Host :
Project : linux-ha
Module : lib
Dir : linux-ha/lib/pils
Modified Files:
pils.c
Log Message:
CID 26, ret was dereferenced before the NULL check.
Actually, this is bogus, because NEW() cannot return NULL, so the deref
is safe. Alas, so is the NULL check, because it cannot ever be NULL
there either ;-) So I've tidied up the code to err on the safe side.
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/lib/pils/pils.c,v
retrieving revision 1.48
retrieving revision 1.49
diff -u -3 -r1.48 -r1.49
--- pils.c 9 Jan 2006 21:27:52 -0000 1.48
+++ pils.c 7 Apr 2006 13:24:05 -0000 1.49
@@ -1,4 +1,4 @@
-/* $Id: pils.c,v 1.48 2006/01/09 21:27:52 alan Exp $ */
+/* $Id: pils.c,v 1.49 2006/04/07 13:24:05 lars Exp $ */
/*
* Copyright (C) 2001 Alan Robertson <[EMAIL PROTECTED]>
* This software licensed under the GNU LGPL.
@@ -796,12 +796,12 @@
}
ret = NEW(PILInterface);
STATNEW(interface);
- ret->MagicNum = PIL_MAGIC_INTERFACE;
if (DEBUGPLUGIN) {
PILLog(PIL_DEBUG, "NewPILInterface(0x%x)", (unsigned long)ret);
}
if (ret) {
+ ret->MagicNum = PIL_MAGIC_INTERFACE;
ret->interfacetype = interfacetype;
ret->exports = exports;
ret->ud_interface = ud_interface;
------------------------------
Message: 4
Date: Fri, 7 Apr 2006 07:27:00 -0600 (MDT)
From: [email protected]
Subject: [Linux-ha-cvs] Linux-HA CVS: lib by lars from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : lars
Host :
Project : linux-ha
Module : lib
Dir : linux-ha/lib/stonith
Modified Files:
stonith.c
Log Message:
CID 21: File descriptor leak.
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/lib/stonith/stonith.c,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -3 -r1.24 -r1.25
--- stonith.c 2 Nov 2005 18:41:14 -0000 1.24
+++ stonith.c 7 Apr 2006 13:26:59 -0000 1.25
@@ -1,4 +1,4 @@
-/* $Id: stonith.c,v 1.24 2005/11/02 18:41:14 blaschke Exp $ */
+/* $Id: stonith.c,v 1.25 2006/04/07 13:26:59 lars Exp $ */
/*
* Stonith API infrastructure.
*
@@ -396,9 +396,11 @@
}else{
line[len] = '\0';
}
-
+
+ fclose(cfgfile);
return stonith_set_config_info(s, line);
}
+ fclose(cfgfile);
return S_BADCONFIG;
}
------------------------------
Message: 5
Date: Fri, 7 Apr 2006 07:36:58 -0600 (MDT)
From: [email protected]
Subject: [Linux-ha-cvs] Linux-HA CVS: lib by lars from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : lars
Host :
Project : linux-ha
Module : lib
Dir : linux-ha/lib/hbclient
Modified Files:
client_lib.c
Log Message:
CID 3: Coverity pointed out that the "if (reply == NULL) {" could never
be false because reply was ZAPMSG()ed just before and thus would always
be NULL, and thus the other error messages would never be displayed.
Moving this to after the error logging.
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/lib/hbclient/client_lib.c,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -3 -r1.36 -r1.37
--- client_lib.c 6 Feb 2006 05:06:31 -0000 1.36
+++ client_lib.c 7 Apr 2006 13:36:57 -0000 1.37
@@ -1,4 +1,4 @@
-/* $Id: client_lib.c,v 1.36 2006/02/06 05:06:31 alan Exp $ */
+/* $Id: client_lib.c,v 1.37 2006/04/07 13:36:57 lars Exp $ */
/*
* client_lib: heartbeat API client side code
*
@@ -684,10 +684,7 @@
ZAPMSG(reply);
}
- if (reply != NULL) {
- zap_nodelist(pi);
- ZAPMSG(reply);
- }
+
if (reply == NULL) {
ha_api_log(LOG_ERR, "General read_api_msg() failure");
}else if (result == NULL) {
@@ -700,6 +697,10 @@
ha_api_log(LOG_ERR, "new_stringlist() failure.");
}
+ if (reply != NULL) {
+ zap_nodelist(pi);
+ ZAPMSG(reply);
+ }
return HA_FAIL;
}
/*
------------------------------
_______________________________________________
Linux-ha-cvs mailing list
[email protected]
http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs
End of Linux-ha-cvs Digest, Vol 29, Issue 34
********************************************
