Send Linux-ha-cvs mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs
or, via email, send a message with subject or body 'help' to
[EMAIL PROTECTED]
You can reach the person managing the list at
[EMAIL PROTECTED]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Linux-ha-cvs digest..."
Today's Topics:
1. Linux-HA CVS: heartbeat by andrew from
([email protected])
2. Linux-HA CVS: lib by andrew from
([email protected])
3. Linux-HA CVS: crm by andrew from
([email protected])
4. Linux-HA CVS: lib by lars from ([email protected])
----------------------------------------------------------------------
Message: 1
Date: Mon, 10 Apr 2006 01:25:03 -0600 (MDT)
From: [email protected]
Subject: [Linux-ha-cvs] Linux-HA CVS: heartbeat by andrew from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : andrew
Host :
Project : linux-ha
Module : heartbeat
Dir : linux-ha/heartbeat
Modified Files:
findif.c
Log Message:
Compile warning: used unitialized
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/heartbeat/findif.c,v
retrieving revision 1.57
retrieving revision 1.58
diff -u -3 -r1.57 -r1.58
--- findif.c 8 Apr 2006 11:07:26 -0000 1.57
+++ findif.c 10 Apr 2006 07:25:03 -0000 1.58
@@ -1,4 +1,4 @@
-/* $Id: findif.c,v 1.57 2006/04/08 11:07:26 lars Exp $ */
+/* $Id: findif.c,v 1.58 2006/04/10 07:25:03 andrew Exp $ */
/*
* findif.c: Finds an interface which can route a given address
*
@@ -213,7 +213,7 @@
unsigned long dest;
long metric = LONG_MAX;
long best_metric = LONG_MAX;
- int rc;
+ int rc = 0;
char buf[2048];
char interface[MAXSTR];
@@ -903,6 +903,9 @@
/*
* $Log: findif.c,v $
+ * Revision 1.58 2006/04/10 07:25:03 andrew
+ * Compile warning: used unitialized
+ *
* Revision 1.57 2006/04/08 11:07:26 lars
* CID 37: Forgot to initialize the variable.
*
------------------------------
Message: 2
Date: Mon, 10 Apr 2006 01:25:24 -0600 (MDT)
From: [email protected]
Subject: [Linux-ha-cvs] Linux-HA CVS: lib by andrew from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : andrew
Host :
Project : linux-ha
Module : lib
Dir : linux-ha/lib/crm/common
Modified Files:
utils.c
Log Message:
The ID field isnt interesting either
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/lib/crm/common/utils.c,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -3 -r1.43 -r1.44
--- utils.c 9 Apr 2006 12:56:13 -0000 1.43
+++ utils.c 10 Apr 2006 07:25:23 -0000 1.44
@@ -1,4 +1,4 @@
-/* $Id: utils.c,v 1.43 2006/04/09 12:56:13 andrew Exp $ */
+/* $Id: utils.c,v 1.44 2006/04/10 07:25:23 andrew Exp $ */
/*
* Copyright (C) 2004 Andrew Beekhof <[EMAIL PROTECTED]>
*
@@ -1130,6 +1130,7 @@
filter_action_parameters(crm_data_t *param_set)
{
const char *attr_filter[] = {
+ XML_ATTR_ID,
XML_LRM_ATTR_OP_DIGEST,
XML_ATTR_TE_TARGET_RC,
XML_ATTR_LRM_PROBE,
------------------------------
Message: 3
Date: Mon, 10 Apr 2006 01:45:04 -0600 (MDT)
From: [email protected]
Subject: [Linux-ha-cvs] Linux-HA CVS: crm by andrew from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : andrew
Host :
Project : linux-ha
Module : crm
Dir : linux-ha/crm/pengine
Modified Files:
incarnation.c native.c
Log Message:
Logging
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/crm/pengine/incarnation.c,v
retrieving revision 1.78
retrieving revision 1.79
diff -u -3 -r1.78 -r1.79
--- incarnation.c 10 Apr 2006 07:23:27 -0000 1.78
+++ incarnation.c 10 Apr 2006 07:45:03 -0000 1.79
@@ -1,4 +1,4 @@
-/* $Id: incarnation.c,v 1.78 2006/04/10 07:23:27 andrew Exp $ */
+/* $Id: incarnation.c,v 1.79 2006/04/10 07:45:03 andrew Exp $ */
/*
* Copyright (C) 2004 Andrew Beekhof <[EMAIL PROTECTED]>
*
@@ -1443,7 +1443,7 @@
if(is_fencing && stonith_op != NULL) {
char *key = started_key(rsc);
- crm_err("Ordering %s before stonith op", key);
+ crm_debug("Ordering %s before stonith op", key);
custom_action_order(
rsc, key, NULL,
NULL, crm_strdup(CRM_OP_FENCE), stonith_op,
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/crm/pengine/native.c,v
retrieving revision 1.124
retrieving revision 1.125
diff -u -3 -r1.124 -r1.125
--- native.c 10 Apr 2006 07:23:27 -0000 1.124
+++ native.c 10 Apr 2006 07:45:03 -0000 1.125
@@ -1,4 +1,4 @@
-/* $Id: native.c,v 1.124 2006/04/10 07:23:27 andrew Exp $ */
+/* $Id: native.c,v 1.125 2006/04/10 07:45:03 andrew Exp $ */
/*
* Copyright (C) 2004 Andrew Beekhof <[EMAIL PROTECTED]>
*
@@ -2066,11 +2066,10 @@
{
gboolean run_unprotected = TRUE;
const char *class = crm_element_value(rsc->xml, XML_AGENT_ATTR_CLASS);
- crm_err("%s class: %s", rsc->id, class);
if(stonith_op != NULL && safe_str_eq(class, "stonith")) {
char *key = start_key(rsc);
- crm_err("Ordering %s before stonith op", key);
+ crm_debug("Ordering %s before stonith op", key);
custom_action_order(
rsc, key, NULL,
NULL, crm_strdup(CRM_OP_FENCE), stonith_op,
------------------------------
Message: 4
Date: Mon, 10 Apr 2006 01:50:15 -0600 (MDT)
From: [email protected]
Subject: [Linux-ha-cvs] Linux-HA CVS: lib by lars from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : lars
Host :
Project : linux-ha
Module : lib
Dir : linux-ha/lib/clplumbing
Modified Files:
ipctransientserver.c
Log Message:
CID 22: Forgot to free memory in error leg.
Also create_simple_message() can return NULL; this wasn't handled.
Probably the send function needs an annotation that it can't take NULL
arguments?
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/lib/clplumbing/ipctransientserver.c,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -3 -r1.13 -r1.14
--- ipctransientserver.c 22 Nov 2004 19:03:01 -0000 1.13
+++ ipctransientserver.c 10 Apr 2006 07:50:14 -0000 1.14
@@ -1,4 +1,4 @@
-/* $Id: ipctransientserver.c,v 1.13 2004/11/22 19:03:01 gshi Exp $ */
+/* $Id: ipctransientserver.c,v 1.14 2006/04/10 07:50:14 lars Exp $ */
/*
* Copyright (C) 2004 Andrew Beekhof <[EMAIL PROTECTED]>
*
@@ -170,6 +170,10 @@
cl_log(LOG_DEBUG, "[Server] Got xml [text=%s]", buffer);
reply = create_simple_message(strdup(buffer), client);
+ if (!reply) {
+ cl_log(LOG_ERR, "[Server] Could allocate reply
msg.");
+ return FALSE;
+ }
llpc = 0;
while(llpc++ < MAX_IPC_FAIL &&
client->ops->send(client, reply) == IPC_FAIL) {
@@ -179,6 +183,7 @@
if(lpc == MAX_IPC_FAIL) {
cl_log(LOG_ERR, "[Server] Could not send IPC,
message. Channel is dead.");
+ free(reply);
return FALSE;
}
------------------------------
_______________________________________________
Linux-ha-cvs mailing list
[email protected]
http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs
End of Linux-ha-cvs Digest, Vol 29, Issue 53
********************************************
