On Mon, 14 Nov 2005, Xun Sun wrote:
Looks fine to me, however could you please check the parameters passed to them are never empty string? I remeber having wrote "We know $1 is not empty beforehand" in some places, where we need not worry about "".
Thanks. Lars had also drawn my attention to that. I have adjusted the patch to account for that.
However please check if you have changed other places, if you have time. I have to rush into the work to submit to my teacher tomorrow...
The whole idea of the other part of this work is so this "ocf_is_decimal" (etc.) becomes a common library, in just one place, called by all. (Earlier, the code had been replicated across lots of separate places.)
Best wishes, and many thanks for your very helpful comments, suggestions and improvements.
-- : David Lee I.T. Service : : Senior Systems Programmer Computer Centre : : Durham University : : http://www.dur.ac.uk/t.d.lee/ South Road : : Durham DH1 3LE : : Phone: +44 191 334 2752 U.K. : _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
