Andrew Beekhof wrote:
I'm no expert, but resources/OCF/IPaddr.in looks broken to me.
The first is this conditional which looks new:
if [ ! -z "$OCF_RESKEY_netmask" ]; then
NICINFO=`$FINDIF "$BASEIP/$NETMASK/$NIC/$BRDCAST"`
else
NICINFO=`$FINDIF "$BASEIP"`
fi
This makes no sense as the next line is:
NICINFO=`$FINDIF "$BASEIP/$NETMASK/$NIC/$BRDCAST"`
I also believe these lines require a -C argument so that when the
netmask is parsed and fed back into $FINDIF later, $FINDIF doesn't barf.
The reason $FINDIF doesn't barf now is that the calculated netmask is
never used. This too is fixed in the attached patch.
I have also included some code to make the parsing of $FINDIF output
work on Darwin.
Possibly its broken on other platforms too.
Permission to apply?
If you can get to it by midnight Friday your time, then go ahead.
--
Alan Robertson <[EMAIL PROTECTED]>
"Openness is the foundation and preservative of friendship... Let me
claim from you at all times your undisguised opinions." - William
Wilberforce
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
