Quoting Ronald Huizer <[EMAIL PROTECTED]>:

> Hi,
>
> Installing heartbeat in order to do a failover setup for some nodes here,
> we encountered curious errors during failover operations related to drbd
> disks.
> On closer inspection, this was because we have a tendency to write out
> pathnames using a trailing slash, which the Filesystem resource script does
> not handle properly; the input value is directly grepped from the output of
> 'mount', which never prints trailing slashes.
>
> Of course the problem is easy to solve, but not after wasting considerable
> time tracking this issue down.
>
> IMHO, it's better to do some input sanitization on the parameter to the
> Filesystem script which strips all trailing slashes. Unified diff included.

Ronald:

I'm travelling at the moment.

Could someone with commit privileges please commit his patch_

--- Filesystem.old      2006-02-17 02:12:46.000000000 +0100
+++ Filesystem  2006-02-17 02:21:47.000000000 +0100
@@ -120,7 +120,7 @@
 }
 # Check the arguments passed to this script
 DEVICE=$1
-MOUNTPOINT=$2
+MOUNTPOINT=`echo $2 | sed -e 's#/*$##'`
 FSTYPE=$3

 case $# in


If it has gotten mangled by this webmail tool, then please ask him to resend it
to you directly.

  Thanks!

    -- Alan Robertson
       [EMAIL PROTECTED]

_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to