On Tue, 8 Aug 2006 10:36:42 +0100 (BST), David Lee wrote:
> On Mon, 7 Aug 2006, Dave Blaschke wrote:
>
>> Alan asked me to run a CVS of the potential 2.0.7 release on my ppc64
>> cluster, but the subject change causes my build to break. I don't have
>> lynx installed, so somehow AC_CHECK_PROG didn't set HTML2TXT to anything
>> (as expected) while the new AC_PATH_PROGS sets HTML2TXT to lynx (not
>> expected as it's not installed) - any ideas?
>
> (Taking the liberty of copying out to "linux-ha-dev"...)
>
> The whole area of:
> (1) AC_CHECK_PROG v. AC_PATH_PROGS
> (2) What to do when not found
>
> was already inconsistent. I had tripped over such an instance (documented
> in the comment to rev 1.539) and the fix was to attempt to improve
> consistency, whilst recognising that it may not yet be perfect.
>
> What is our ("linux-ha-dev") policy?
>
> We seem to be preferring AC_PATH_PROGS (deprecating AC_CHECK_PROG). This
> certainly has my vote. (And my 1.539 rev is in line with this.)
>
> But when a particular instance is absent (in your case "HTML2TXT"/"lynx")
> then what to do? I suspect this is instance-specific.
>
> IIRC, I also used to have problems with absent lynx a couple of years
> back. That woulkd result in "make" in "doc/" failing in peculiar ways
> as it still tried to execute a command (blank) so the actual command
> attempt was not:
> lynx -dump ...
> but became
> -dump ...
> Horrible!
>
> Let's check... yes, see "doc/Makefile.am" revs 1.18 and 1.19.
>
> Perhaps my recent 1.539 rev should itself be adjusted to leave HTMLTEXT
> blank if not found (i.e. perhaps I accidentally introduced worse behaviour
> for the "not found" case).
>
> BUT WAIT...
>
> I see that events are overtaking us as we e-speak, and that Alan is
> updating CVS here, to look for both "lynx" and a thing called "w3m".
> I see that he has made this:
> AC_PATH_PROGS(HTML2TXT, lynx, w3m)
>
> Perhaps that ought to be:
> AC_PATH_PROGS(HTML2TXT, lynx w3m)
>
> (i.e. 2nd arg a two word string, 3rd arg blank).
I'd say the later, the fomer seems to be a typo (or misreading of the docs).
With this in place I think that the missing HTML2TXT problem should
be resolved.
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
Index: configure.in
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/configure.in,v
retrieving revision 1.543
diff -u -r1.543 configure.in
--- configure.in 7 Aug 2006 20:42:42 -0000 1.543
+++ configure.in 8 Aug 2006 10:46:29 -0000
@@ -383,7 +383,7 @@
AC_SYS_LARGEFILE
-AC_PATH_PROGS(HTML2TXT, lynx, w3m)
+AC_PATH_PROGS(HTML2TXT, lynx w3m)
case $HTML2TXT in
*/*) ;;
*) HTML2TXT="";;
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
