On Tue, 8 Aug 2006, Lars Marowsky-Bree wrote: > On 2006-08-08T13:25:48, David Lee <[EMAIL PROTECTED]> wrote: > > > PLEASE APPLY A FIX like this before shipping 2.0.7. > > > > (Slightly deeper: why call `ha_parameter crm` twice? Wouldn't it be better > > to call once, save the result, and then use that result twice?) > > Actually, that test is the only user of CheckBool. I've taken the > liberty to rename this to CrmEnabled and put the additional check into > that function. > > The tag for 2.0.7 has been moved. Does this work for you?
Thanks. It works, but I think it is potentially unstable. Your new code introduces: ... | tr A-Z a-z But in traditional "tr" implementations this only does the letters A and Z not the range A through Z. (That is "B, C, ... X, Y" remain untouched.) Better would be the bracketed-and-quoted: ... | tr '[A-Z]' '[a-z]' And I see two other instances of "tr" in the same file using similar flawed (non-square-bracketed) specifications. (Doubtless other files also contain similar weaknesses, but let's not upset them at the moment.) Could you make the adjustment, please? (If you want me to do it, I will, but I'm deferring to you and Alan at this perilously-close-to-release point!) -- : David Lee I.T. Service : : Senior Systems Programmer Computer Centre : : Durham University : : http://www.dur.ac.uk/t.d.lee/ South Road : : Durham DH1 3LE : : Phone: +44 191 334 2752 U.K. : _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
