Serge Dubrouski wrote:
> Why enable_fatal_warnings is set to "yes" by default?

Because this is the only reliable way I know of to make sure that we
don't ignore warnings.  It's a very effective technique ;-).

I strongly believe in code correctness, and using automated tools to
help us to the greatest degree possible.  So, making warnings fatal is
part of that process.  Of course, not all warnings are serious, but
there's no mechanical way to tell if a warning is serious or not.
Setting -Werror forces all the developers to manually examine each
warning and see if it is serious or not.  And, in spite of the size of
our code base, we compile with zero warnings on Linux (and some other
OSes too).

As another part of this process, the code is also run through two
different program verifiers (BEAM and Coverity) on a regular basis.  We
run the project through BEAM every night - with annoying messages sent
to the responsible developers every night until the problems it finds
are fixed.  Usually all new problems get fixed within a few days.

Regarding your second question, it appears that Andrew has already
answered it...

> It adds -Werror
> flag to all Makefiles and then compiling Heartbeat fails on machines
> where bzip-devel or ncurses-devel packages aren't installed. But those
> packages aren't critical.
> Other way crm_mon.c and xml.c have to be patched to correctly process
> this problem.


-- 
    Alan Robertson <[EMAIL PROTECTED]>

"Openness is the foundation and preservative of friendship...  Let me
claim from you at all times your undisguised opinions." - William
Wilberforce
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to