I think it's a good idea to unify the commit comments. I would like to
follow them.
BTW, sorry for the unclear comment "GUI: Fix OSDL 1415: use
xxx-xxx-xxx to replace xxx_xxx_xxx"
(http://hg.linux-ha.org/dev?cmd=changeset;node=64516dbe675b).
It should be "use new attribute name like xxx-xxx (like
stonith-enabled) to replace old name xxx_xxx(like stonith_enabled)"
On 11/7/06, Alan Robertson <[EMAIL PROTECTED]> wrote:
I'd like to suggest what I think is a simple but useful policy for
dealing with commits to Mercurial which correspond to bug reports.
1) Most or all commits should have associated bugzillas. If you don't
have a bugzilla for at least 90% of your commits, you should make
more bugzillas. 100% is the desired outcome.
2) For each commit associated with a bugzilla, the bug number should
appear in the first line in a style something like this:
OSDL # 1234 blah blah blah
Novell # 183216 blah blah blah blah
LTC # 24752 blah blah blah blah
3) For each bug which has been marked as fixed, the changeset submitted
to -dev should be indicated by URL. An example of what I mean can be
found in OSDL bugzilla 1443.
http://www.osdl.org/developer_bugzilla/show_bug.cgi?id=1443
Note that in this case, it took me two changesets to really resolve
the bug. Both are indicated in the bugzilla. This bug doesn't
follow my suggested guidelines perfectly - in the 2nd changeset it
just says "Bugzilla 1443" instead of "OSDL 1443". The appearance
of the # sign would also be an improvement, I think...
In an ideal world these things could be followed consistently enough
that one could write a tool that given any changeset could find the
bugzilla for it and vice versa. But, failing that, it would be good if
humans could do it quickly and easily.
Comments? Suggestions?
--
Alan Robertson <[EMAIL PROTECTED]>
"Openness is the foundation and preservative of friendship... Let me
claim from you at all times your undisguised opinions." - William
Wilberforce
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
--
Best Regards,
Huang Zhen (zhenh)
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
