Hi, Is there anything else I can do to get this included in the HA package?
Rgds Oza >>> On Mon, Nov 13, 2006 at 3:30 PM, in message <[EMAIL PROTECTED]>, "Oza Dhairesh" <[EMAIL PROTECTED]> wrote: > Hi, > > Finally got the time to work on this. I have now made it mandatory to > have a "pid file" entry in the rsyncd.conf file for the RA to work. > Please find attached, the patch. > > Rgds > Oza > > >>>> Lars Marowsky-Bree <[EMAIL PROTECTED]> 11/02/06 10:12 PM >>> > On 2006-11-02T08:22:36, Oza Dhairesh <[EMAIL PROTECTED]> wrote: > >> Lars, Dejan thanks for the suggestions. After giving it some more >> thought, I think not allowing the user to use rsync daemon with the >> default setup (my default rsyncd.conf file does not have the pid file >> entry) would be too harsh as on most setups I expect just a single >> instance of rsync to be running. > > The reason why there's no pid file by default is that, at least on SUSE, > the init script will kill all rsyncd processes on "stop". > > We can, however, easily modify the default packaging to include a PID > file. > >> instances of rsync daemon running and the config file does not have a >> pid file entry then and then only I can create it manually. This way >> only if a daemon comes up between the time of my testing for it and >> launching of the daemon, there will be error. But as this is a rare case >> on most setups, it should work most of the times. > > If you use "startproc", like the init script does, this will not be an > issue. It even has a -p option to write the pidfile for you. > > It's perfectly reasonable to expect that people don't just use the > default configuration with the OCF RA; if that's what they wanted to do, > they could simply use the rsyncd LSB script, afterall. > >> In case this is not acceptable, do let me know and I will submit the >> RA that disallows starting the daemon if there is no pid file entry in >> the config file. I am attaching just the rsyncd.in for the time being. >> After incorporating comments on this, I shall submit the complete patch. > > > Sincerely, > Lars Marowsky-Brée > > -- > High Availability & Clustering > SUSE Labs, Research and Development > SUSE LINUX Products GmbH - A Novell Business -- Charles Darwin > "Ignorance more frequently begets confidence than does knowledge." > > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
