On 12/18/06, Lars Ellenberg <[EMAIL PROTECTED]> wrote:
/ 2006-12-18 11:24:19 +0100
\ Andrew Beekhof:
> On 12/14/06, Lars Ellenberg <[EMAIL PROTECTED]> wrote:
> >/ 2006-12-01 21:29:09 +0100
> >\ Lars Marowsky-Bree:
> >> On 2006-12-01T11:00:20, Philipp Reisner <[EMAIL PROTECTED]> wrote:
> >>
> >> > What is the procedure to get such further patches into your
> >> > repository ?
> >>
> >> It'd be easiest if you could send a patch or provide a hg repo to pull
> >> from.
> >
> >I just pushed this to dev/
> >
> >changeset: 9860:6c16e96d191a
> >tag: tip
> >user: lge
> >date: Thu Dec 14 12:53:21 2006 +0100
> >summary: Checkin of the DRBD Outdate Peer Daemon plugin.
> >
>
> perhaps i wasn't concentrating, but did we agree to take this while I
> wasn't looking?
my fault, I thought we did (well, you'd pull; pushing was easier for me
than setting up an externally accessible repo).
> what i'm not understanding is why this needs to be in our codebase
> instead of yours.
basically because we are lazy :)
it is/will become cumbersome to have the suitable heartbeat sources for
all the different distributions and build this thing for all of them.
is already hard enough to have all the different kernel configs and
headers and stuff to build drbd for all sorts of distribution/kernel
combination. since this depends on the heartbeat communication
infrastructure, we thought its best having it built by you and available
whenever heartbeat is used.
looking briefly at the code, my initial impression is that one should
be able to build it with just the libs and headers installed by
heartbeat (ie. without the heartbeat source)
if there's some reason you can't, then i'd be happy to help figure out
why and make any required changes. not because I dont want the code
in our repo, but because we shouldn't be making it so hard for you
(and others) that it _must_ be there.
> and if it does need to be in ours, it should be in the contrib directory
right, from your point of view this is obviously contrib.
for me it was "tool", next to attrd,
where it stole some of its implementation from.
I'd really like to see this in the normal heartbeat rpm.
How can I go about convincing you that it would be good for both
heartbeat and drbd if you'd include it, now that I pissed you off by
pushing it without your consent?
not pissed off - just seeking clarification :-)
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
