On 2/7/07, YAMAMOTO Takashi <[EMAIL PROTECTED]> wrote:
hi,
changeset e36b4e692dbe commented out cib_GHFunc in cib_msg_timeout.
why?
as the commit log doesn't seem to mention it at all,
i wonder if it was an intentional change.
wow, you're really reviewing a lot of code! thankyou!
i wasn't happy with how the timeout code worked (i'd prefer it was in
the client-side library). so rather than have something that worked
only half the time, i removed it with the intention of writing
something better. unfortunately i've not had a chance to do that yet.
YAMAMOTO Takashi
@@ -1132,7 +1207,7 @@ cib_msg_timeout(gpointer data)
cib_msg_timeout(gpointer data)
{
crm_debug_4("Checking if any clients have timed out messages");
- g_hash_table_foreach(client_list, cib_GHFunc, NULL);
+/* g_hash_table_foreach(client_list, cib_GHFunc, NULL); */
return TRUE;
}
changeset: 7856:e36b4e692dbe
user: andrew
date: Thu Feb 02 11:10:32 2006 +0000
files: crm/cib/callbacks.c crm/cib/callbacks.h crm/cib/main.c
description:
Specify a setup and teardown function for each query
- cleaner, more maintainable and avoids a mess of booleans
Improved stats (average request time)
Some performance enhancements
- defer calls for things until we enter the block that sometimes uses them
CVS patchset: 8559
CVS date: 2006/02/02 11:10:32
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
