On 2007-02-09T16:43:50, Andrew Beekhof <[EMAIL PROTECTED]> wrote:

Wow, Andrew, thanks for the work here and fixing all of this!

> == NEVER AGAIN ==
> 
> The embarrassment of such a leak being present has prompted me to  
> make running the CRM under Valgrind exceedingly easy.  Simply give  
> the --enable-valgrind option to configure and all 5 CRM processes  
> will complain bitterly if they're leaking memory (with a stack trace  
> of who allocated it!).  Just remember to start a Valgrind lister on  
> localhost:1234.

Cool. You wouldn't be interested in making this available for all
heartbeat processes, would you? ;-)

I hope that we'll soon get feedback from Coverity as well again.


> When running tools like Valgrind, please remember that there are  
> results that I cannot do anything about. Eg:
> * library functions that leak every time they're called

Are there any of these on SLES?

> * library functions that create "global" data and offer no way to  
> clean it up^
> 
> For this reason, I have created a Valgrind suppression file which I  
> can make available if people are interested.

Yes, can you please just check that into hg as well?

> ^ Technically this isn't a leak, since its a fixed size regardless of  
> the number of times a function is called, but it does make spotting  
> real leaks harder.


Sincerely,
    Lars

-- 
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business     -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge."

_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to