On Thu, Apr 26, 2007 at 04:25:20PM +0200, Dejan Muhamedagic wrote:
> On Thu, Apr 26, 2007 at 10:00:10AM +0200, Andrew Beekhof wrote:
> > On 4/26/07, Simon Horman <[EMAIL PROTECTED]> wrote:
> > >----- Forwarded message from Simon Horman <[EMAIL PROTECTED]> -----
> > >
> > >Date: Mon, 23 Apr 2007 11:25:36 +0900
> > >From: Simon Horman <[EMAIL PROTECTED]>
> > >To: Erich Schubert <[EMAIL PROTECTED]>, [EMAIL PROTECTED]
> > >Subject: Re: Bug#420206: heartbeat-2: Bashism in IPAddr2
> > >Message-ID: <[EMAIL PROTECTED]>
> > >References: <[EMAIL PROTECTED]>
> > >MIME-Version: 1.0
> > >Content-Type: text/plain; charset=us-ascii
> > >Content-Disposition: inline
> > >In-Reply-To: <[EMAIL PROTECTED]>
> > >User-Agent: mutt-ng/devel-r804 (Debian)
> > >Status: RO
> > >Content-Length: 567
> > >Lines: 20
> > >
> > >On Fri, Apr 20, 2007 at 08:38:59PM +0200, Erich Schubert wrote:
> > >> Package: heartbeat-2
> > >> Version: 2.0.7-2
> > >> Severity: normal
> > >>
> > >> The IPAddr2 script contains bashisms.
> > >> /usr/lib/ocf/resource.d/heartbeat/IPaddr2:
> > >>
> > >>
> > >IF_MAC=${IF_MAC:0:2}:${IF_MAC:2:2}:${IF_MAC:4:2}:${IF_MAC:6:2}:${IF_MAC:8:2}:${IF_MAC:10:2}
> > >>
> > >> Hotfix: replace /bin/sh in the first line by /bin/bash
> > >> Other scripts might be affected as well.
> > >
> > >Thanks, I'll get this fixed. Please let me know if you find any more.
> >
> > i'll push up a fix momentarily
>
> Since IPaddr2 is Linux specific, I guess it's OK to have it run by
> bash.
No I don't think so. In debian space at least its not uncommon
to use dash and not have bash installed at all. If we really can't
change this then yes, I can change the dependancies so bash will
always be there. But I can recall numerous occasions in this
project alone where I have been wrapped on the knuckles for letting
bashims creep in. So I always assumed they were taboo, and for
good enough reason too.
I thought the ip command exists on Solaris, so I guess in theory
IPaddr2 could be made to work there too.
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
