On Wed, Aug 08, 2007 at 11:44:37PM -0600, Sean Reifschneider wrote: > Attached is a patch for the ipmilan STONITH plugin. The good news is that > it does now properly parse the arguments as described in the documentation. > the "auth" now properly takes "admin" or "operator", and "priv" takes > "none", "md5", "md2"... Previously it was just doing an atoi on these > strings which always returned 0. > > This sees to solve the problem of STONITH reporting: > > CRITICAL **: Unable to setup connection: 16 > > The other good news is that it now does reset the system on my test > machines (Dell 1920). > > The bad news is that it then pukes with: > > *** glibc detected *** stonith: munmap_chunk(): invalid pointer: > 0x00007fff2dfc6d70 *** > > The worse news is that ipmilan uses a deprecated API call to do it's work. > Possibly because of this, it seems to be entirely undocumented, from what I > can see. > > So, I wouldn't exactly call ipmilan fixed, but it sucks less. > > I'd recommend that ipmilan just be removed. It almost certainly needs > to be rewritten before it can be useful, as it needs to at least use the > new API. horms suggested that one alternative would be to add a configure > option for "--enable-ipmilan", and have it be disabled by default. > > As it is quite unhappy, I'm just going to switch to the external STONITH > plugin and use a script calling "ipmitool"...
Thanks, I have applied this change dev and sent a few patches of my own for review. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
