On Nov 9, 2007, at 7:12 AM, Keisuke MORI wrote:


Hello all,

I would like to propose an extention for the SNMP hbagent
so that it can handle the CRM resource information provided by
Heartbeat Version 2.

cool!



The attached patch is my proposal implementation.
The patch is already tested and debugged by our team
with using valgrind.


I would appreciate any comments and suggestions
to make it more usable for everybody in the community.

you might want to include so other data (such as failed, is_managed, etc) in the trap

also, it might be an idea to include a back-link for resources that are in groups/clones/etc


<quote>
NOTE : This trap is sent only when the resource operation succeeds. Concretely, the extended hbagent gets the cib information when it changes, and parse it. And if the rc_code of the operation (like
           CRMD_ACTION_START) is "0", then the hbagent sends a trap.
</quote>

it worries me a little that you only send the trap when rc=0...
you don't want to know about failed actions?

The patch is separated into two parts and please apply them in the order:

1) 1_hbagent_memory_leak.patch
Fix memory leaks that's existing in the current code reported by valgrind.
2) 2_hbagent_v2resource.patch
    The main patch for the new function.

Please see the README below for the details.

Best regards,

Keisuke MORI
NTT DATA Intellilink Corporation

< README_hbagentv2 .txt > < 1_hbagent_memory_leak .patch > < 2_hbagent_v2resource .patch>_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to