Hi, On Tue, Nov 20, 2007 at 09:48:28AM +0900, DAIKI MATSUDA wrote: > Hi, Heartbeat Develepers all. > > I found the broken file in CVS Dev tree source code. It is > lib/plugin/stonith/ipmilan.c and I paste the diff. > By comparing with 2.1.2 source, ipmilan_set_config has been changed > and may be bug.
Thanks for looking into this. There were some news on this stonith agent and at some point it was disabled in the distribution (i.e. not built anymore): http://marc.info/?l=linux-ha&m=119241755500666&w=2 http://marc.info/?l=linux-ha-dev&m=118665242231256&w=2 Do you have this device? If so, could you test these patches? Cheers, Dejan > Best Regards > MATSUDA, Daiki > > [EMAIL PROTECTED] stonith]$ diff -uNrp ipmilan.c.orig ipmilan.c > --- ipmilan.c.orig 2007-11-20 09:21:04.000000000 +0900 > +++ ipmilan.c 2007-11-20 09:43:29.000000000 +0900 > @@ -435,10 +435,9 @@ ipmilan_set_config(StonithPlugin* s, Sto > LOG(PIL_CRIT, "ipmilan priv value is NULL. See " > "README.ipmilan for allowed values"); > return S_OOPS; > - if (strcmp(namestocopy[4].s_value, "operator") == 0) { > + } else if (strcmp(namestocopy[4].s_value, "operator") == 0) { > tmp->privilege = 3; > - } > - if (strcmp(namestocopy[4].s_value, "admin") == 0) { > + } else if (strcmp(namestocopy[4].s_value, "admin") == 0) { > tmp->privilege = 4; > } else { > LOG(PIL_CRIT, "ipmilan priv value '%s' invalid. See " > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
