On Nov 19, 2007, at 3:32 AM, Keisuke MORI wrote:
Dejan,
Dejan Muhamedagic <[EMAIL PROTECTED]> writes:
Hi,
On Tue, Oct 30, 2007 at 08:53:54PM +0900, Keisuke MORI wrote:
Hi,
I've been testing the heartbeat with valgrind enabled,
and found that it reported a couple of leaks which are
in the heartbeat API client library.
I'm submitting my proposed patch to fix them, so
could somebody please review it and the correctness?
In my understanding, these leaks are not so serious
because the leaks only happens when the heartbeat exits,
but it may be a problem if a HB client does signon()/signoff()/
delete()
repeatedly in a single process.
(omit)
Your patch is in this changeset:
http://hg.linux-ha.org/dev/rev/84e6520764bf
Thank you for taking care of it.
BTW, do you have hg write access?
No, I don't.
Is there any authorization procedure to gain the access?
now that we use a distributed SCM there is little need for this anymore.
instead, you can commit the changes to your own copy of the repository
and make it available online.
then all you need is someone to periodically "pull" your changes into
the "main" repository (which is much less work because hg handles most
merges automagically :-).
and even if no-one does, your changes will still be preserved even
when you get the latest upstream changes.
which is not to say you shouldn't have write access, just that not
having it isn't the limitation it once was (back in the days of CVS).
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
