Hi, On Sat, Mar 08, 2008 at 02:59:00AM +0900, YAMAUCHI HIDEO wrote: > Hi All, > > I wrote a patch of oralce-RA and oralsnr-RA. > > A summary of each patch is the next contents. > > (oralce-RA) > 1.I supported fail over with the backup mode. > When a clear_backupmode parameter is appointed, and there is it, I examine > a backup mode. > And I remove a backup mode. > If we do not appoint this parameter, oracle is the same as a former > version.
Does this influence in any way the shutdown method? Wouldn't shutdown abort take care of this automatically? What I'm worried about is that this command might hang under some circumstances. > 2.I revised it to be able to output log of oracle precisely. > This revision is sake corresponding to the problem of our character code. > > (old) SU $ORACLE_OWNER > (new) SU - $ORACLE_OWNER Are you refering to the Japanese language environment? Can you elaborate further on this? The difference betwen 'su' and 'su -' is that the latter executes the startup scripts such as .profile. I can't recall exactly anymore, but I think that there was a reason why I've chosen 'su' and not 'su -'. > 3.Like oralsnr, I changed it to use the runasdba function. > The reason is because it thought that I am easy to watch a similar source. oracle and oralsnr share some code, but, unfortunately, it hasn't been put into a separate file. That's why there is runasdba in oracle even though it is not used. Perhaps now that we have OCF_ROOT we can also take care of that. Note that runasdba means exactly what it says: run a command as the dba user. The change you made also changes the meaning, i.e. we should rename the function for example to execsql. > 4.I changed it for a step-by-step stop. > The first stop is too dangerous in abort. > For security, you had better stop from immediate sequentially. Is there a chance for shutdown immediate to hang? Did you test this under various (and unfavourable) circumstances? Again, can't recall exactly (need new memory ;-), but I think that there was a reason not to use shutdown immediate at all. > (oralsnr-RA) > 1.For our demand of a special customer, I added the restart of monitor > disorder. > This patch permits only one time of monitor error of oralsnr. > It limits outbreak in fail over by a problem only for oralsnr. > For this function, I added a parameter of require_once. > If we do not appoint this parameter, oralsnr is the same as a former > version. Must say that I don't like this, i.e. restarting the service in the monitor operation. It would be preferable to either fix the service or use the CRM configuration to deal with occasional service failures. Anyway, why does this happen? > 2.I revised it to be able to output log of oralsnr precisely. > This revision is sake corresponding to the problem of our character code. > > (old) SU $ORACLE_OWNER > (new) SU - $ORACLE_OWNER > > 3.I revised a spelling error. > pATH -> PATH Oops. Wonder how did this typo survive for such a long time. > Give me an opinion about this patch and if there is not a problem, please > adopt it. There is one typo: dbsql instead of dbasql. The patch is much bigger than it should be because there's a mix of spaces and tabs in indentation. That makes it hard to follow what has changed. Can you please use only tabs for indentation. Cheers, Dejan > Best Regards, > Hideo Yamauchi. > > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
