Hi Lars, > What is the point of this particular call, directly before calling exit? Sorry. This is a wrong patch.
I review the whole a little more, too. Thank you. Hideo Yamauchi. --- Lars Marowsky-Bree <[EMAIL PROTECTED]> wrote: > On 2008-09-09T16:35:43, HIDEO YAMAUCHI <[EMAIL PROTECTED]> wrote: > > Hi, > > let's move this discussion to the dev list. > > diff -r 928aeea6ee26 stonithd.c > --- a/stonithd.c Tue Sep 09 16:04:47 2008 +0900 > +++ b/stonithd.c Tue Sep 09 16:05:13 2008 +0900 > @@ -3212,6 +3214,7 @@ stonithRA_stop( stonithRA_ops_t * ra_op, > return pid; > } > > + setpgid(0,0); > /* in child process */ > exit(0); > } > > What is the point of this particular call, directly before calling exit? > > The entire fork() block in stontihRA_stop() is completely pointless and > should be removed, not added to ;-) > > The code otherwise looks pretty good, even though stonithd.c has a lot > of redundancy and the fork() etc routines really should be consolidated > and use more of the clplumbing infrastructure ... > > > Regards, > Lars > > -- > Teamlead Kernel, SuSE Labs, Research and Development > SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N将舐nberg) > "Experience is the name everyone gives to their mistakes." -- Oscar Wilde > > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ > _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
