Andrew,

Thank you so much for taking care of it!


Regards,
Satomi TANIGUCHI



Andrew Beekhof wrote:
Thanks!

Applied as:
   http://hg.clusterlabs.org/pacemaker/dev/rev/c6326dbb9fac

2008/9/9 Satomi Taniguchi <[EMAIL PROTECTED]>:
Hi,

I found that crm_get_msec() is declared to return _unsigned_ long long,
but it tries to return a minus value in the following cases.
 i) input strings consists of only character string.
ii) input strings means minus value.
In these cases, the return value is unexpected one like 1271310319.

I think this function should be declared to return _signed_ value,
but it is used in so many places without minus value check.
I tentatively created a patch , but I could'nt clarify its influence...

Anyway, I just want to use crm_get_msec()'s function safely.
If it is possible as it is, please let me know.

Regards,
Satomi Taniguchi


_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to