Hi, On Thu, Dec 11, 2008 at 12:11:44PM +0100, Dominik Klein wrote: > Andrew Beekhof wrote: > > On Wed, Dec 10, 2008 at 16:51, Dejan Muhamedagic <[email protected]> > > wrote: > >>> diff -r 057a73385865 -r 1a5685e8f1ed resources/OCF/drbd > >>> --- a/resources/OCF/drbd Tue Dec 02 20:29:32 2008 +0100 > >>> +++ b/resources/OCF/drbd Tue Dec 09 16:10:12 2008 +0100 > >>> @@ -383,7 +383,11 @@ drbd_monitor() { > >>> ocf_log debug "$RESOURCE monitor: resource not configured" > >>> return $OCF_NOT_RUNNING > >>> elif [ "$DRBD_STATE_LOCAL" = "Primary" ]; then > >>> -# drbd_update_prefs > >>> + if [ -z "$OCF_RESKEY_CRM_meta_interval" ]; then > >> shouldn't this be: > >> > >> if [ -z "$OCF_RESKEY_CRM_meta_interval" -o > >> "$OCF_RESKEY_CRM_meta_interval" -eq 0 ]; then > >> > > > > It's unset if the interval is 0. > > That may or may not be ok to rely on. > > > > Personally I favor adding: > > > > : ${OCF_RESKEY_CRM_meta_interval=0} > > > > and testing for 0 > > If you ever change your mind and not leave it empty but really put the 0 > into that var during probes, both would still work :)
Your slightly modified patch applied. Cheers, Dejan > I don't care which you choose. > > Regards > Dominik > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
