All these patches are OK with one exception. Construction $(command) isn't supported by native Bourne shell so I'd propose changing it to `command`. Attached is a patch that combines all 3 patches and fixes that incompatibility issue.
Thanks for the patches. 2009/6/18 NAKAHIRA Kazutomo <[email protected]> > Hello, > > The pgsql RA includes the several confusing logs as follows > and I propose 3 patches to solve these problems. > > 1. When it takes time to start PostgreSQL, the "ERROR" level log > "PostgreSQL $OCF_RESKEY_pgdb isn't running" is output > though the start of pgsql RA has succeeded. > It seems that "WARN" level is more appropriate than "ERROR". > > pgsql-ra-logging-1.patch is a patch that corrects No.1 problem. > > 2. In the start confirmation processing of pgsql RA, An unnecessary > "sleep 1" is executed though the start of PostgreSQL is confirmed > with pgsql_monitor(). > 3. In the stop processing of pgsql RA, An unnecessary log message > "PostgreSQL still hasn't stopped yet. Waiting..." is output to > the ha-debug though PostgreSQL has been stopped. > > pgsql-ra-logging-2.patch is a patch that corrects No.2 and 3 problem. > > 4. When failing in the execution of the psql command and > the pg_ctl command, the execution result of the command is not > recorded in the log file. > > pgsql-ra-logging-3.patch is a patch that corrects No.4 problem. > > Best regards, > NAKAHIRA Kazutomo > > -- > ---------------------------------------- > NAKAHIRA Kazutomo > NTT DATA INTELLILINK CORPORATION > Open Source Business Unit > Software Services Integration Business Division > > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ > > -- Serge Dubrouski.
_______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
