Hi,
On Mon, Jun 29, 2009 at 11:41:52AM +0200, Florian Haas wrote:
> Dejan,
>
> On 2009-06-29 11:31, Dejan Muhamedagic wrote:
> > Hi,
> >
> > On Tue, Jun 23, 2009 at 03:01:56PM +0200, Florian Haas wrote:
> >> A set of incremental improvements to the iSCSITarget and
> >> iSCSILogicalUnit RAs:
> >>
> >> - iSCSITarget: replace the ugly "while read" loop on connection
> >> shutdown with something prettier.
> >>
> >> - iSCSITarget: add ACL support to allow access by initiator IP
> >> address. On IET, this manages entries in the
> >> /etc/initiators.{allow,deny} files. On tgt, it allows initiators
> >> using the "tgtadm --op bind" commant.
> >>
> >> - iSCSILogicalUnit: add support for per-LU parameters.
> >
> > Applied.
>
> Thanks.
>
> >> Questions: should I rename the instance attribute "params" to
> >> "parameters", so as to avoid confusion with the CRM shell's "params"
> >> command?
> >
> > Yes, probably. The parser may even become nervous ;-)
>
> Will do.
>
> >> And, should the "initiators" instance attribute be renamed to
> >> "allowed-initiators" to remove ambiguity?
> >
> > Yes. BTW, it won't work if the configuration's changed back from
> > some to none, so perhaps you should remove those files in that
> > case.
>
> You lost me there. What files are you referring to? And what is it
> exactly that won't work?
Sorry. The /etc/initiators.deny and such. If the user first
specifies some initiators and runs the resource, then later
changes it to empty, the files won't change, i.e. the "none" case
is not enforced. Which also gets me thinking about multiple
iSCSITarget instances. Perhaps you need a more elaborate scheme
here. Or perhaps just give up on it and tell users to set it
themselves? :)
Cheers,
Dejan
> Cheers,
> Florian
>
> _______________________________________________________
> Linux-HA-Dev: [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
