On 12.08.2009 17:32, Dejan Muhamedagic wrote: *snip* >> because then something is broken. i reworked this part now >> and am checking if the directory exists, "[ -d ... ]" return<> 0, at >> least on my linux box using bash. > > This is from a diff: > > + [ -d "$queue" ] || return 1 # check if queue directory is empty @TODO > shall we return false or $OCF_ERR_something > > I guess you meant to say: "check if queue is a directory"?
yes, i meant to say that :) > This got too complicated. Again, part of the diff: > > + # try some different methods to see if we can find a running > postfix/master instance > + # postfix status > + $binary $OPTION_CONFIG_DIR status>/dev/null 2>&1&& return $OCF_SUCCESS > > Shouldn't this be enough? Is there a chance that "postfix status" > would lie? If not, then you wouldn't even need to fiddle with the > pid file. And it seems to me preferable to leave this to the > postfix itself: it should really know the best. i'd say yes ;) > No need to repost the whole script again, I already edited it to > fix some false false(1) usage and reduce some noise :) (note that > false doesn't change the order of execution just exits with code 1). ok - i then can't wait for the commit ;) cheers, raoul -- ____________________________________________________________________ DI (FH) Raoul Bhatia M.Sc. email. r.bha...@ipax.at Technischer Leiter IPAX - Aloy Bhatia Hava OEG web. http://www.ipax.at Barawitzkagasse 10/2/2/11 email. off...@ipax.at 1190 Wien tel. +43 1 3670030 FN 277995t HG Wien fax. +43 1 3670030 15 ____________________________________________________________________ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
