New patch attached, should have all the word wrapping, comments and trailing whitespace fixed.
Re 'ldirectord status' returning non-zero on a stale PID file is correct: depends on your point of view I guess. I want to have ldirectord running as much as possible and so want the RA to recover from things I don't consider a serious problem. If ldirectord has died badly in the past and the PID file is still around, I want it to be considered 'not running' and thus a candidate for the resource starting as opposed to being 'broken' on a node. The downside is the RA hides a potential problem with service crashing. My hard line opinion though is "I don't care, ldirectord is important, just get it back up and running somewhere". Perhaps the nicest way would be to have a new resource attribute describing whether a stale PID file is to be ignored or not, so people have a choice. Thoughts? Luke Bigum Systems Administrator (p) 1300 661 668 (f) 1300 661 540 (e) [email protected] http://www.iseek.com.au Level 1, 100 Ipswich Road Woolloongabba QLD 4102 This e-mail and any files transmitted with it may contain confidential and privileged material for the sole use of the intended recipient. Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorised to receive for the recipient), please contact the sender by reply e-mail and delete all copies of this message. -----Original Message----- From: Simon Horman [mailto:[email protected]] Sent: Friday 30 October 2009 10:11 AM To: Luke Bigum Cc: '[email protected]' Subject: Re: [Linux-ha-dev] patch for ldirectord RA On Fri, Oct 30, 2009 at 09:04:45AM +1000, Luke Bigum wrote: > Here's a patch for the ldirectord resource agent. Makes the RA a lot more > OCF compliant and generally more robust, comments inline. Questions / > problems please ask. Hi Luke, this looks good to me. A few comments inline.
ldirectord.patch.2
Description: ldirectord.patch.2
_______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
