On 12/23/2009 at 12:42 AM, Jiaju Zhang <jjzhang.li...@gmail.com> wrote: 
> On Tue, Dec 22, 2009 at 8:56 PM, Dejan Muhamedagic <deja...@fastmail.fm> 
> wrote: 
> >> Thank you for stepping forward! 
> > 
> > Jiaju, many thanks for the contribution. Any chance to also 
> > implement the suggested improvements? 
>  
> Sure :) 
> Thanks for all the suggestions. I'll improve it and update it soon. 

Small bugfix:

  # diff -u IPaddr2 IPaddr2.new 
  --- IPaddr2   2009-12-22 14:02:48.847303603 +1100
  +++ IPaddr2.new       2009-12-23 19:07:16.798028769 +1100
  @@ -532,6 +532,7 @@
   }
   
   save_tcp_connections() {
  +     [ -z "$OCF_RESKEY_tickle_dir" ] && return
        mydir=$OCF_RESKEY_tickle_dir/`hostname`
        rm -f $mydir/*

Also, I suppose it's kind of obvious, but might be worth mentioning
in the tickle_dir metadata that the directory needs to be on shared
storage.

Regards,

Tim


-- 
Tim Serong <tser...@novell.com>
Senior Clustering Engineer, Novell Inc.



_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to