On Fri, Feb 05, 2010 at 12:30:13PM +0100, Dejan Muhamedagic wrote: > Hi Simon, > > On Fri, Feb 05, 2010 at 10:54:21AM +1100, Simon Horman wrote: > > utillib.sh ha_cf_support.sh and openais_conf_support.sh are not scripts, > > rather thay are "libraries" of shell functions. As such they shouldn't > > be installed as executable. With this in mind it seems that the DATA > > target is more appropriate than the SCRIPTS target. > > > > This problem was flagged by lintian, for more information see: > > http://lintian.debian.org/tags/executable-not-elf-or-script.html > > > > Signed-off-by: Simon Horman <[email protected]> > > > > Index: cluster-glue-1.0.really.1.0.2.rc1/hb_report/Makefile.am > > =================================================================== > > --- cluster-glue-1.0.really.1.0.2.rc1.orig/hb_report/Makefile.am > > 2010-02-04 09:13:02.000000000 +0900 > > +++ cluster-glue-1.0.really.1.0.2.rc1/hb_report/Makefile.am 2010-02-04 > > 09:14:14.000000000 +0900 > > @@ -21,7 +21,8 @@ MAINTAINERCLEANFILES = Makefile.in > > > > hanoarchdir = $(datadir)/heartbeat > > > > -hanoarch_SCRIPTS = utillib.sh ha_cf_support.sh \ > > - openais_conf_support.sh combine-logs.pl > > +dist_hanoarch_DATA = utillib.sh ha_cf_support.sh \ > > + openais_conf_support.sh > > +hanoarch_SCRIPTS = combine-logs.pl > > sbin_SCRIPTS = hb_report > > This has been fixed in the meantime: > > changeset: 2287:98dc36dd16cf > user: Dejan Muhamedagic <[email protected]> > date: Thu Jan 07 13:27:52 2010 +0100 > summary: Low: build: install combine-logs.pl as executable script > > changeset: 2285:ce57c3d4ecfc > user: Dejan Muhamedagic <[email protected]> > date: Tue Dec 29 16:35:37 2009 +0100 > summary: Low: build: install hb_report support scripts as data > > The dir above says 1.0.2.rc1 which is oldish, but the date is > newish, which all makes me somewhat uneasy.
If its fixed upstream then thats fine. We can carry the changes in the Debian package until it gets rebased on newer source. _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
