Marek, I've finally found time to look into this. Sorry about the delay. So to recap, based on the patches list in http://marmarek.w.staszic.waw.pl/patches/ha-mysql-ra/,
01 has gone in. 02 has gone in. 03 has gone in. 04 has gone in. 05 has gone in but I think it ought to be reverted and replaced with a change in functionality, not documentation. Why not check whether the resource is configured as a M/S, and if yes, actually _start_ mysqld with --skip-slave-start rather than expecting the user to add this to the config? 06 has not gone in, but I'm generally OK with it. But, please, "START SLAVE", not "SLAVE START". And on a different style note, no reason for trailing semicolons after ocf_log and return. 07 has gone in. 08 has not gone in. It's nice but I hate the way it's implemented with a state file. Why not use crm_attribute and stick transient attributes onto nodes? If we could get that patch rewritten to use transient node attributes I'd like to see this go in. But here too: "STOP SLAVE" please, not "SLAVE STOP". 09: not in, comments on 06 and 05 apply here too. What are your thoughts on this? Cheers, Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
