Hi Serge, On Thu, Sep 16, 2010 at 08:41:50AM -0600, Serge Dubrouski wrote: > Dejan - > > Did you not notice this patch or it's no good?
Still behind with the ML traffic after the vacation. > There was also a small patch for pgsql a couple weeks ago. OK. The patch is fine, it's just that some RA do need to change too. After identifying and fixing single RAs we can apply the patch. Cheers, Dejan > Thanks. > > > On Tue, Sep 14, 2010 at 10:13 AM, Serge Dubrouski <[email protected]> wrote: > > Hello - > > > > Attached is a patch for ocf_run function in .ocf_shellfunc. The patch > > make ocf_run to return an actual exit code from the command it ran. > > That allows RAs to implement a better logic for handling error > > situations. Following RAs use ocf_run function: > > > > apache > > exportfs > > ICP > > iSCSILogicalUnit > > iSCSITarget > > LVM > > mysql > > ServerRAID > > Squid > > syslog-ng > > > > Most of them do not check error code from ocf_run or check that is > > zero/non zero. pgsql has some extended logic to provide additional > > information to the client based on that error code. So the patch will > > benefit pgsql and won't hurt other RAs. > > > > Thanks. > > > > -- > > Serge Dubrouski. > > > > > > -- > Serge Dubrouski. > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
