On Thu, Nov 04, 2010 at 04:52:49PM +0100, Dejan Muhamedagic wrote: > Hi, > > On Thu, Nov 04, 2010 at 08:54:02AM -0600, Serge Dubrouski wrote: > > Honestly I've never liked that fuser. No doubt that it's too expensive > > to run it in every status/monitor operation. But this proposed > > solution make pgsql RA incompatible with other operation systems, > > Solaris in particular. So instead I'd propose following patch: > > > > @@ -441,7 +441,7 @@ > > if [ -f $PIDFILE ] > > then > > PID=`head -n 1 $PIDFILE` > > - kill -s 0 $PID >/dev/null 2>&1 && fuser $OCF_RESKEY_pgdata > > 2>&1 | grep $PID >/dev/null 2>&1 > > + runasowner "kill -s 0 $PID >/dev/null 2>&1" > > return $? > > fi > > > > It would guarantee that process with that PID is up and owned by > > pg_dba user. I believe that here we can assume that that process is > > PosgressSQL database. Further check with running sql monitor will make > > it sure. > > > > The complete patch is attached. > > This looks good enough to me. If nobody other objects, I'd apply > this patch.
Dejan, you asked it yourself: why do we need to kill $PID at all, anyways? Why not directly do the sql monitoring? -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD® and LINBIT® are registered trademarks of LINBIT, Austria. _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
