On Tue, Apr 26, 2011 at 03:36:35PM +0200, Florian Haas wrote:
> Thanks Darren!
> 
> Thanks for the contribution! Can I suggest
> 
> - we move this discussion to the linux-ha-dev list (where most OCF RA
> related discussions and reviews take place);
> 
> - you give the RA a makeover following the OCF RA developer's guide
> (http://www.linux-ha.org/doc/dev-guides/ra-dev-guide.html);
> 
> - you set up your own github fork off of
> https://github.com/ClusterLabs/resource-agents, and push your RA to that
> so we can eventually pull it into the mainline repo?
> 
> Also, can you explain what the advantages of your approach are, versus
> using libvirt-managed lxc containers which Pacemaker can tie into via
> the existing VirtualDomain agent?

Yes, this is the first thing I thought about too.

A few remarks:

- the "required" attributes in meta-data need to be reviewed,
  a parameter is either required or has a default, cannot be
  both

- why use screen(1) in start?

BTW, since lxc seems to be easy to setup, it would be great to
supply an ocft test file along with the RA. It's quite
straightforward, just make a copy of one of the existing test
files from tools/ocft.

Cheers,

Dejan

> Thanks!
> Cheers,
> Florian
> 



> _______________________________________________
> Openais mailing list
> [email protected]
> https://lists.linux-foundation.org/mailman/listinfo/openais
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to