Hi, On Tue, May 10, 2011 at 04:00:28PM +0200, Lars Marowsky-Bree wrote: > On 2011-05-06T09:37:09, Florian Haas <florian.h...@linbit.com> wrote: > > > To use it, set "op monitor interval=X OCF_CHECK_LEVEL=Y" > > The spec never decreed that this was how it has to be configured, just > that this was the way how the environment variable had to be passed in. > (The idea being that it wouldn't collide with the other instance > attributes.) > > > Yes, it's poorly designed, it makes no sense why this is pretty much the > > only sensible time to set a parameter specifically for an operation (as > > opposed to on a resource), it's inexplicable why it's all caps, etc., > > but that's the way it is. > > I think you're overstating the badness of the design here. The intent to > keep the namespaces of RA-defined instance attributes (OCF_RESKEY_*) > separate from those that are defined by the spec is, I believe, actually > a valid concern; it allows new definitions that can't possibly collide > with already existing RA-defined ones, and thus seems superior/cleaner > to reserving names within the same namespace. > > (And "all caps" is how many standards defined their keywords. Not that > bad.) > > I'd not be a fan of lumping the "depth" parameter into the OCF_RESKEY_* > space.
There's a bunch of OCF_RESKEY_CRM_meta_*, that sounds like a good way to subdivision a name space, though a bit too verbose. We could do something similar for the depth parameter. The way it is now, it does look like a sore thumb in monitor definitions. Cheers, Dejan > Regards, > Lars > > -- > Architect Storage/HA, OPS Engineering, Novell, Inc. > SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, > HRB 21284 (AG Nürnberg) > "Experience is the name everyone gives to their mistakes." -- Oscar Wilde > > _______________________________________________________ > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
