Hi, On Mon, Nov 14, 2011 at 09:53:12PM +0100, Florian Haas wrote: > Dejan, Lars, and other shell gurus in attendance, > > maybe I'm totally off my rocker, and one of you guys can set me > straight. But to me this part of the ocf_run function seems a bit fishy: > > output=`"$@" 2>&1` > rc=$? > output=`echo $output`
> Am I gravely mistaken, or would any funny control characters produced by > the wrapped command line totally mess up the content of "output" here as > it is mangled by the backticks? I think you're not :) The last line was most probably put there to convert CR to spaces. > What I'm noticing is the invocation of "ocf_run sipsak -v -s <uri>", > which we put into the asterisk RA as per Russell Bryant's suggestion, > seems to totally garble the output. > > Compare this: > > $ sipsak -v -s sip:[email protected] 2>&1 > SIP/2.0 200 OK > Via: SIP/2.0/UDP > 127.0.0.1:43665;branch=z9hG4bK.539207ad;rport=53485;alias;received=85.127.155.32 > From: sip:[email protected]:43665;tag=6dafacb9 > To: > sip:[email protected];tag=c64e1f832a41ec1c1f4e5673ac5b80f6.3109 > Call-ID: [email protected] > CSeq: 1 OPTIONS > Server: Kamailio (1.5.3-notls (i386/linux)) > Content-Length: 0 > > To this: > > $ output=`sipsak -v -s sip:[email protected] 2>&1` > $ echo $output > Content-Length: 0(1.5.3-notls > (i386/linux))tag=c64e1f832a41ec1c1f4e5673ac5b80f6.8ff585.127.155.32 Seems like part of the output goes to stdout and another part to stderr. The two are interspersed in an unpredictable manner. Apart from saving the two separately, I'm not sure what can be done. > In this case it appears to be due to carriage-return (0x0d, ^M) > characters that sipsak injects into its output, which is annoying but > relatively benign. But maybe we want to sanitize the ocf_run output > before we hand it off to be written to the logs? Sanitize in the security sense? I guess that the log writer should do that. Or make the message looks nicer? I'm all for that, certainly. Cheers, Dejan > Cheers, > Florian > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
