On Wed, Feb 01, 2012 at 02:32:27PM +0900, Keisuke MORI wrote:
> Hi Dejan,
>
> 2012/1/31 Dejan Muhamedagic <[email protected]>:
> > Hi Keisuke-san,
> >
> > On Tue, Jan 31, 2012 at 09:52:24PM +0900, Keisuke MORI wrote:
> >> Hi Dejan
> >>
> >> 2012/1/31 Dejan Muhamedagic <[email protected]>:
> >> > Hi Keisuke-san,
> >> (...)
> >> > On Tue, Jan 31, 2012 at 08:46:35PM +0900, Keisuke MORI wrote:
> >> >> The current RA will try to check the top page (http://localhost:80)
> >> >> as the default behavior if you have not enabled server-status in
> >> >> httpd.conf
> >> >> and it would fail to start even for the apache's default test page:)
> >> >
> >> > Hmm, the current RA would produce an error for that URL:
> >> >
> >> > 488 case $STATUSURL in
> >> > 489 http://*/*) ;;
> >> > 490 *)
> >> > 491 ocf_log err "Invalid STATUSURL $STATUSURL"
> >> > 492 exit $OCF_ERR_ARGS ;;
> >> > 493 esac
> >>
> >> Strange. That URL is generated by the RA itself.
> >>
> >> apache-conf.sh:
> >> 119 buildlocalurl() {
> >> 120 [ "x$Listen" != "x" ] &&
> >> 121 echo "http://${Listen}"; ||
> >> 122 echo "${LOCALHOST}:${PORT}"
> >>
apache-conf.sh actually does, in GetParams,
StatusURL=`FindLocationForHandler $1 server-status | tail -1`
STATUSURL="`buildlocalurl`$StatusURL"
Where StatusURL, as found by FindLocationForHandler <config file> server-status,
is supposed to end up being /server-status (or similar),
so STATUSURL in fact should match http://*/*
> >> Probably we should relax the validation pattern, as just 'http://*' ?
> >
> > Agreed. I thought that the intention was to always use the status
Yes, I think it is intentional.
> > page, but obviously people figured out that they could skip that.
> > Just as well.
>
> Thank you for your productive comments and discussions!
>
> As the result of the discussion regarding to this topic,
> I would suggest two patches as the pull request below:
> https://github.com/ClusterLabs/resource-agents/pull/54
We can do that anyways, but why?
--
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
