Hi Tomo, On Tue, Mar 27, 2012 at 10:27:36AM +0900, nozawat wrote: > Hi > > Even if kill fails in terminate, return success. > When kill fails, this is the patch which I revised to return an error > definitely.
This patch doesn't look right. What if the first kill(1) fails (because, say, the process just exited)? And if '$result' is -ne 0, then the while loop will finish anyway. Anyway, the terminate function looks too complicated for what it does. Can we also do a global replace s/result/rc/? Cheers, Dejan > Regards, > Tomo > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
