Look at start function. If one sets rootdir parameter to / , then start
function strips it and monitor fails. So the patch fixes it.
On Oct 3, 2012 7:45 AM, "Dejan Muhamedagic" <[email protected]> wrote:
> Hi Serge,
>
> On Mon, Oct 01, 2012 at 08:29:50PM -0600, Serge Dubrouski wrote:
> > Hi, Dejan -
> >
> > Will you apply it?
>
> The grep ps part I'll apply. I was just curious why the previous
> version didn't work, but I guess it's not worth the time to
> investigate.
>
> And I'm trying to understand this part:
>
> named_getpid () {
> local pattern="$OCF_RESKEY_named"
>
> - if [ -n "$OCF_RESKEY_named_rootdir" ]; then
> + if [ -n "$OCF_RESKEY_named_rootdir" -a "x${OCF_RESKEY_named_rootdir}"
> != "x/" ]; then
> pattern="$pattern.*-t $OCF_RESKEY_named_rootdir"
> fi
>
> How would named_rootdir be set to "/" unless the user sets it as
> a parameter? Why would "/" then be treated differently?
>
> Cheers,
>
> Dejan
>
> > On Fri, Sep 28, 2012 at 5:09 AM, Serge Dubrouski <[email protected]>
> wrote:
> >
> > > Yes it is. It also includes a fix for a small bug. So 2 lines changed.
> > > On Sep 28, 2012 2:54 AM, "Dejan Muhamedagic" <[email protected]> wrote:
> > >
> > >> Hi Serge,
> > >>
> > >> On Sat, Sep 22, 2012 at 09:11:53AM -0600, Serge Dubrouski wrote:
> > >> > Hello -
> > >> >
> > >> > Attached a short patch for named RA to fix improve getpid function.
> > >>
> > >> Sorry for the delay. Is this the same as
> > >> https://github.com/ClusterLabs/resource-agents/issues/134
> > >> and
> > >> https://github.com/ClusterLabs/resource-agents/pull/140
> > >>
> > >> Cheers,
> > >>
> > >> Dejan
> > >>
> > >> > --
> > >> > Serge Dubrouski.
> > >>
> > >>
> > >> > _______________________________________________________
> > >> > Linux-HA-Dev: [email protected]
> > >> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > >> > Home Page: http://linux-ha.org/
> > >>
> > >> _______________________________________________________
> > >> Linux-HA-Dev: [email protected]
> > >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > >> Home Page: http://linux-ha.org/
> > >>
> > >
> >
> >
> > --
> > Serge Dubrouski.
>
> > _______________________________________________________
> > Linux-HA-Dev: [email protected]
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
>
> _______________________________________________________
> Linux-HA-Dev: [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
