On Mon, Apr 08, 2013 at 02:33:27PM +0100, Tim Small wrote: > On 13/03/13 18:01, Dejan Muhamedagic wrote: > > > If you could split the > > patch we can consider them on a one-by-one basis. > > I used Debian's "start-stop-daemon" utility in my modified script, and > it looks like Redhat etc. doesn't package it (yet): > http://fedoraproject.org/wiki/Features/start-stop-daemon > > ... the comments in that page express why I chose to use > start-stop-daemon - reworking the script to have the same level of > functionality as the start-stop-daemon version (but just using lsb > stuff) would be a bit awkward + time-consuming. > > How about I use start-stop-daemon where available, and the LSB functions > when not? This would still represent an improvement on the current > behaviour of the script - which is pretty broken - e.g. stopping an > already-stopped resource fails, and stuff like this: > > > # > # This is always active, because it doesn't do much > # > sendarp_monitor() { > return $OCF_SUCCESS > } > > > > and this: > > > > sendarp_status() { > if > [ -f "$SENDARPPIDFILE" ] > then > return $OCF_SUCCESS > else > return $OCF_NOT_RUNNING > fi > } > > > "A pid file is there, so it must be running!"
The fix for the resource agent itself is already in the repository. It is based on the standard ha_pseudo_* functions like in any other pseudo agents (i.e. those that don't have long running processes). > > Otherwise, I found some patch in my local queue, which never got pushed for > > some reason. Don't know if that would help (attached). > > > > I'll have a go with them, and check to see if they fix the bug which I > was seeing. Did you get a chance to verify the two patches attached? There's now also a pull request for the socket leaks issue at github.com: https://github.com/ClusterLabs/resource-agents/pull/247 Cheers, Dejan > Tim. > > > -- > South East Open Source Solutions Limited > Registered in England and Wales with company number 06134732. > Registered Office: 2 Powell Gardens, Redhill, Surrey, RH1 1TQ > VAT number: 900 6633 53 http://seoss.co.uk/ +44-(0)1273-808309 > > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
