Hi, Dejan Could you incorporate this patch? I want some messages.
Regards, Yusuke 2013/6/3 yusuke iida <[email protected]>: > Hi, Dejan > > 2013/4/18 Dejan Muhamedagic <[email protected]>: >> Hi Yusuke-san, >> >> On Tue, Apr 16, 2013 at 02:55:40PM +0900, yusuke iida wrote: >>> Hi, Dejan >>> >>> 2013/4/4 Dejan Muhamedagic <[email protected]>: >>> > Hi Yusuke, >>> > >>> > On Thu, Feb 21, 2013 at 09:04:45PM +0900, yusuke iida wrote: >>> >> Hi, Dejan >>> >> >>> >> I also tested by rhel6.3 and fedora17. >>> >> Since there is no environment, centos is not tested. >>> >> >>> >> The point worried below is shown: >>> >> - I think that %{?fedora_version} and %{?rhel_version} are macro not to >>> >> exist. >>> > >>> > Those macros work in OBS when rhel6 packages are built. I wonder >>> > if that's some build service extension. >>> >>> In my environment, the macro of rpmbuild is as follows. >>> >>> rhel6.3 >>> # rpmbuild --showrc | grep rhel >>> -14: rhel 6 >>> >>> fedora18 >>> # rpmbuild --showrc | grep fedora >>> -14: fedora 18 >>> >>> So I want you to revise it as follows at least. >>> >>> # hg diff >>> diff -r da93d3523e6a crmsh.spec >>> --- a/crmsh.spec Tue Mar 26 11:44:17 2013 +0100 >>> +++ b/crmsh.spec Tue Apr 16 13:08:37 2013 +0900 >>> @@ -6,7 +6,7 @@ >>> %global upstream_version tip >>> %global upstream_prefix crmsh >>> >>> -%if 0%{?fedora_version} || 0%{?centos_version} || 0%{?rhel_version} >>> +%if 0%{?fedora_version} || 0%{?centos_version} || 0%{?rhel_version} >>> || 0%{?rhel} || 0%{?fedora} >>> %define pkg_group System Environment/Daemons >>> %else >>> %define pkg_group Productivity/Clustering/HA >> >> Patch applied. Thanks! >> >>> >> - pssh is not provided in rhel. >>> >> I think that you should not put it in Requires. >>> > >>> > OK, but currently the only RPM built is the one in OBS where the >>> > repository includes pssh RPMs for rhel/centos too. See for >>> > instance: >>> > >>> > http://download.opensuse.org/repositories/network:/ha-clustering/RedHat_RHEL-6/x86_64/ >>> > >>> >> I made a patch to solve the above. >>> > >>> > Note that the .spec file in the upstream may not be perfect or >>> > even work on particular distribution. However, it should advise >>> > packagers on what it should contain. The pssh requirement is >>> > there because history would not work well without it. It is >>> > further rather unfortunate that that feature is used very seldom >>> > and that it got so little attention. >>> > >>> > Therefore, I'm reluctant to apply the pssh part of the patch. >>> >>> hmm ... >>> For example, can't it change so that the function in which pssh is >>> used may be disabled by the configure option? >> >> The functionality is still there, even without pssh. For >> instance, static reports can also be examined. It's just that the >> live updates are going to be quite a bit slower, if somebody >> wants to use the history feature to examine changes happening in >> the cluster. > I made sure the source code. > > In the environment where pssh is not supported, history was collecting > information using the crm_report command. > Furthermore, the processing which is using pssh was found. It is rsctest. > > This processing serves as an error of python in the environment where > pssh is not supported. > > Probing resources .Traceback (most recent call last): > File "/usr/sbin/crm", line 44, in <module> > main.run() > File "/usr/lib64/python2.6/site-packages/crmsh/main.py", line 413, in run > do_work() > File "/usr/lib64/python2.6/site-packages/crmsh/main.py", line 323, in > do_work > if parse_line(levels,shlex.split(' '.join(l))): > File "/usr/lib64/python2.6/site-packages/crmsh/main.py", line 149, > in parse_line > rv = d() # execute the command > File "/usr/lib64/python2.6/site-packages/crmsh/main.py", line 148, in > <lambda> > d = lambda: cmd[0](*args) > File "/usr/lib64/python2.6/site-packages/crmsh/ui.py", line 1945, in > rsc_test > return test_resources(rsc_l, node_l, all_nodes) > File "/usr/lib64/python2.6/site-packages/crmsh/rsctest.py", line > 300, in test_resources > if not are_all_stopped(rsc_l, all_nodes_l): > File "/usr/lib64/python2.6/site-packages/crmsh/rsctest.py", line > 250, in are_all_stopped > drv.runop("probe") > File "/usr/lib64/python2.6/site-packages/crmsh/rsctest.py", line 143, in > runop > from crm_pssh import do_pssh_cmd > File "/usr/lib64/python2.6/site-packages/crmsh/crm_pssh.py", line > 24, in <module> > from psshlib import psshutil > ImportError: No module named psshlib > > Since I thought that this was a problem, I added the processing which > checks support of pssh. > > If there is no problem, I want you to apply this patch. > > Regards, > Yusuke >> >>> If it is possible, can it not exclude pssh from Requires? >> >> I already reasoned in my previous message (quoted above) why I'm >> reluctant to do that. >> >> Cheers, >> >> Dejan >> >>> Regards, >>> Yusuke >>> > >>> > Cheers, >>> > >>> > Dejan >>> > >>> >> Regards, >>> >> Yusuke >>> >> >>> >> 2013/2/19 Dejan Muhamedagic <[email protected]>: >>> >> > On Tue, Feb 19, 2013 at 11:03:53AM +0100, Dejan Muhamedagic wrote: >>> >> >> On Fri, Feb 15, 2013 at 10:19:41PM +0100, Dejan Muhamedagic wrote: >>> >> >> > Hi, >>> >> >> > >>> >> >> > On Fri, Feb 15, 2013 at 02:25:41PM +0900, yusuke iida wrote: >>> >> >> > > Hi, Dejan >>> >> >> > > >>> >> >> > > I made a patch for spec file to make rpm of crmsh in rhel >>> >> >> > > environment. >>> >> >> > > I want a crmsh repository to merge it if I do not have any >>> >> >> > > problem. >>> >> >> >>> >> >> This is a problem which I ran into earlier too. Something >>> >> >> (probably one of the rpm macros) does a 'rm -rf' of the doc >>> >> >> directory _after_ the files got installed: >>> >> >> >>> >> >> [ 29s] test -z "/usr/share/doc/packages/crmsh" || /bin/mkdir -p >>> >> >> "/var/tmp/crmsh-1.2.5-build/usr/share/doc/packages/crmsh" >>> >> >> [ 29s] /usr/bin/install -c -m 644 'AUTHORS' >>> >> >> '/var/tmp/crmsh-1.2.5-build/usr/share/doc/packages/crmsh/AUTHORS' >>> >> >> [ 29s] /usr/bin/install -c -m 644 'COPYING' >>> >> >> '/var/tmp/crmsh-1.2.5-build/usr/share/doc/packages/crmsh/COPYING' >>> >> >> ... >>> >> >> [ 30s] Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.6245 >>> >> >> [ 30s] + umask 022 >>> >> >> [ 30s] + cd /usr/src/packages/BUILD >>> >> >> [ 30s] + cd crmsh >>> >> >> [ 30s] + >>> >> >> DOCDIR=/var/tmp/crmsh-1.2.5-build/usr/share/doc/packages/crmsh >>> >> >> [ 30s] + export DOCDIR >>> >> >> [ 30s] + rm -rf >>> >> >> /var/tmp/crmsh-1.2.5-build/usr/share/doc/packages/crmsh >>> >> >> [ 30s] + /bin/mkdir -p >>> >> >> /var/tmp/crmsh-1.2.5-build/usr/share/doc/packages/crmsh >>> >> >> [ 30s] + cp -pr ChangeLog >>> >> >> /var/tmp/crmsh-1.2.5-build/usr/share/doc/packages/crmsh >>> >> >> ... >>> >> >> [ 32s] error: create archive failed on file >>> >> >> /var/tmp/crmsh-1.2.5-build/usr/share/doc/packages/crmsh/AUTHORS: >>> >> >> cpio: open failed - Bad file descriptor >>> >> >> >>> >> >> If somebody can shed some light or suggest how to deal with >>> >> >> this ... >>> >> > >>> >> > OK. I think I managed to fix it. The result is already upstream. >>> >> > I tested it with rhel6, centos6, fedora 17 and 18. Can you >>> >> > please test too. >>> >> > >>> >> > Thanks, >>> >> > >>> >> > Dejan >>> >> > >>> >> >> Thanks, >>> >> >> >>> >> >> Dejan >>> >> >> >>> >> >> >>> >> >> > No problem. Will test the patch. BTW, did you notice that there >>> >> >> > are packages for rhel too at OBS (see the latest news item at >>> >> >> > https://savannah.nongnu.org/projects/crmsh/). >>> >> >> > >>> >> >> > Cheers, >>> >> >> > >>> >> >> > Dejan >>> >> >> > >>> >> >> > > >>> >> >> > > Best regards, >>> >> >> > > Yusuke >>> >> >> > > -- >>> >> >> > > ---------------------------------------- >>> >> >> > > METRO SYSTEMS CO., LTD >>> >> >> > > >>> >> >> > > Yusuke Iida >>> >> >> > > Mail: [email protected] >>> >> >> > > ---------------------------------------- >>> >> >> > >>> >> >> > >>> >> >> > _______________________________________________________ >>> >> >> > Linux-HA-Dev: [email protected] >>> >> >> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev >>> >> >> > Home Page: http://linux-ha.org/ >>> >> >> _______________________________________________________ >>> >> >> Linux-HA-Dev: [email protected] >>> >> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev >>> >> >> Home Page: http://linux-ha.org/ >>> >> > _______________________________________________________ >>> >> > Linux-HA-Dev: [email protected] >>> >> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev >>> >> > Home Page: http://linux-ha.org/ >>> >> >>> >> >>> >> >>> >> -- >>> >> ---------------------------------------- >>> >> METRO SYSTEMS CO., LTD >>> >> >>> >> Yusuke Iida >>> >> Mail: [email protected] >>> >> ---------------------------------------- >>> > >>> > >>> >>> >>> >>> -- >>> ---------------------------------------- >>> METRO SYSTEMS CO., LTD >>> >>> Yusuke Iida >>> Mail: [email protected] >>> ---------------------------------------- >> _______________________________________________________ >> Linux-HA-Dev: [email protected] >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev >> Home Page: http://linux-ha.org/ > > > > -- > ---------------------------------------- > METRO SYSTEMS CO., LTD > > Yusuke Iida > Mail: [email protected] > ---------------------------------------- -- ---------------------------------------- METRO SYSTEMS CO., LTD Yusuke Iida Mail: [email protected] ---------------------------------------- _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
