On Mon, 30 Apr 2007, David Lee wrote: > [...] > We already have such code, and already have it duplicated (ouch!) in > "resources/OCF/IPaddr.in" and "resources/heartbeat/IPaddr.in". And > "pingd.sh" is in danger of making this triplicate. > [...]
Following my own email above, and going to a slightly tangential issue... In almost all cases "resources/heartbeat/BLAH" is now just a minimal wrapper around the corresponding "resources/OCF/BLAH" which does the real work. But in the case of "IPaddr", the "/heartbeat/" version still does the "monitor" operation itself instead of passing it through to the "/OCF/" version. Curious. Is there a good reason for this discrepancy? Could this be rationalised? Any gotchas to beware? Returning from the tangent... I have prepared and tested a patch which moves the construction of the 'ping' argument list into a function 'pingargs' in "shellfuncs". The caller then simply does something like: PINGARGS="`pingargs $IP`" @PING@ $PINGARGS (For non-autoconf readers here: you may read "@PING@" as "/usr/sbin/ping" or whatever the location of the ping command is on the host OS.) Our existing use of ping is currently "do a single packet and use a fixed timeout to prevent undue waiting". My comments in the patch indicate how, in future, extra things may be done if desired. -- : David Lee I.T. Service : : Senior Systems Programmer Computer Centre : : UNIX Team Leader Durham University : : South Road : : http://www.dur.ac.uk/t.d.lee/ Durham DH1 3LE : : Phone: +44 191 334 2752 U.K. : _______________________________________________ Linux-HA mailing list [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
