On Thu, May 24, 2007 at 03:29:45PM -0400, Brian Reichert wrote:
> This is the patch to 2.0.8 that I'm testing:
>
> # diff -U3 heartbeat/heartbeat.c.orig heartbeat/heartbeat.c
> --- heartbeat/heartbeat.c.orig 2007-01-11 21:57:05.000000000 -0500
> +++ heartbeat/heartbeat.c 2007-05-23 12:27:38.000000000 -0400
> @@ -4934,7 +4934,7 @@
>
> /* See if heartbeat is already running... */
>
> - if ((pid=cl_read_pidfile(PIDFILE)) > 0 && pid != getpid()) {
> + if ((pid=cl_read_pidfile(PIDFILE)) > 0 && pid != getpid() &&
> CL_KILL(pid,0)) {
This test is unneccessary; it seems that cl_read_pidfile() already
tests for existance of the pid in the file. So, this patch is
unneccesary..
Still makes that bad assumption that it's an extant heartbeat prcoess,
though.
--
Brian Reichert <[EMAIL PROTECTED]>
55 Crystal Ave. #286 Daytime number: (603) 434-6842
Derry NH 03038-1725 USA BSD admin/developer at large
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems
