Hi,
On Wed, Jan 02, 2008 at 04:38:00PM +0800, Chun Tian (binghe) wrote:
> Hi, Linux-HA Developers
>
> I found a little coding bug in lib/plugins/stonith/ipmilan.c which cause
> compiling failed when --enable-ipmilan, as in attach.
>
> diff -r 7cea5a8c5c0e lib/plugins/stonith/ipmilan.c
> --- a/lib/plugins/stonith/ipmilan.c Fri Dec 21 23:13:06 2007 -0700
> +++ b/lib/plugins/stonith/ipmilan.c Wed Jan 02 16:34:51 2008 +0800
> @@ -435,6 +435,7 @@ ipmilan_set_config(StonithPlugin* s, Sto
> LOG(PIL_CRIT, "ipmilan priv value is NULL. See "
> "README.ipmilan for allowed values");
> return S_OOPS;
> + }
> if (strcmp(namestocopy[4].s_value, "operator") == 0) {
> tmp->privilege = 3;
> }
>
Thanks for the patch.
> Thanks.
>
> Chun TIAN (binghe)
>
> diff -r 7cea5a8c5c0e lib/plugins/stonith/ipmilan.c
> --- a/lib/plugins/stonith/ipmilan.c Fri Dec 21 23:13:06 2007 -0700
> +++ b/lib/plugins/stonith/ipmilan.c Wed Jan 02 16:34:51 2008 +0800
> @@ -435,6 +435,7 @@ ipmilan_set_config(StonithPlugin* s, Sto
> LOG(PIL_CRIT, "ipmilan priv value is NULL. See "
> "README.ipmilan for allowed values");
> return S_OOPS;
> + }
> if (strcmp(namestocopy[4].s_value, "operator") == 0) {
> tmp->privilege = 3;
> }
On Tue, Jan 08, 2008 at 09:30:36AM +0900, DAIKI MATSUDA wrote:
> Hi
>
> I have already posted,
> http://www.gossamer-threads.com/lists/linuxha/dev/43863
>
> But it stops. If you have the machine with IPMI interface, could you
> test my patch?
Right, this has also been spotted by Daiki Matsuda.
> Regards
> MATSUDA, Daiki
>
> 2008/1/2, Chun Tian (binghe) <[EMAIL PROTECTED]>:
> > Hi, Linux-HA Developers
> >
> > I found a little coding bug in lib/plugins/stonith/ipmilan.c which cause
> > compiling failed when --enable-ipmilan, as in attach.
> >
> > diff -r 7cea5a8c5c0e lib/plugins/stonith/ipmilan.c
> > --- a/lib/plugins/stonith/ipmilan.c Fri Dec 21 23:13:06 2007 -0700
> > +++ b/lib/plugins/stonith/ipmilan.c Wed Jan 02 16:34:51 2008 +0800
> > @@ -435,6 +435,7 @@ ipmilan_set_config(StonithPlugin* s, Sto
> > LOG(PIL_CRIT, "ipmilan priv value is NULL. See "
> > "README.ipmilan for allowed values");
> > return S_OOPS;
> > + }
> > if (strcmp(namestocopy[4].s_value, "operator") == 0) {
> > tmp->privilege = 3;
> > }
> >
> > Thanks.
> >
> > Chun TIAN (binghe)
On Tue, Jan 08, 2008 at 08:49:14AM +0100, Thomas Glanzmann wrote:
> Hello,
>
> > But it stops. If you have the machine with IPMI interface, could you
> > test my patch?
>
> do you have a confugration for me. I have a machine with ipmi and the
> external/ipmi stonith works for me. If you can walk me through
> configuring ipmilan I can give it a spin.
Configuration is comparable to the external/ipmi. Just check the
parameter names and adjust the stonith type.
There have been more patches contributed for the ipmilan stonith
module, which, apparently, is not in the best shape. For some
time I've been preparing to tackle this issue and recently, a
kind colleague at SuSE provided an IPMI device. I'll try to
collect all the patches and see if there's anything more wrong
with the thing, but hopefully there's a chance to have ipmilan
back on board again. Thomas, if you could also do additional
testing, that'd be great.
Thanks,
Dejan
> Thomas
> _______________________________________________
> Linux-HA mailing list
> [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha
> See also: http://linux-ha.org/ReportingProblems
--
Dejan
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems
