On Jan 31, 2008, at 5:59 AM, Junko IKEDA wrote:
Hi,
I run this combination.
Heartbeat changeset: 3aa6bea6a251
Pacemaker changeset: 01ca13de726c
When I execute crm_standby, it would say like this;
(process:10181): GLib-CRITICAL **: g_source_remove: assertion `tag >
0'
failed
It just display an error, crm_standby command do well.
By the way, is it needed to "sig_src->gsourceid" as 0?
Looks like the order of those two lines should be reversed.
However thats not the problem here as we're not invoking
G_main_del_SignalHandler()
I had a fix for this locally but apparently forgot to commit it
yesterday - thanks for reminding me.
http://hg.clusterlabs.org/pacemaker/dev/rev/41b359f6822d
On the subject of reminders... you're aware of the difference between
the dev and stable-0.6 repositories right?
Some substantial changes are going to be occurring in dev soon - so
chances are _something_ will break and I'd hate for you find out on a
production server.
/lib/clplumbing/GSource.c
gboolean
G_main_del_SignalHandler(GSIGSource* sig_src)
{
GSource* source = (GSource*) sig_src;
if (sig_src->gsourceid <= 0) {
return FALSE;
}
if(_NSIG <= sig_src->signal) {
g_assert(_NSIG > sig_src->signal);
return FALSE;
}
CL_SIGNAL(sig_src->signal, NULL);
sig_src->gsourceid = 0; /* ????? */
sig_src->signal_triggered = FALSE;
g_source_remove(sig_src->gsourceid); /* ????? */
G_main_signal_list[sig_src->signal] = NULL;
g_source_unref(source);
return TRUE;
}
g_source_remove() function checks the tag value.
gboolean
g_source_remove (guint tag)
{
GSource *source;
g_return_val_if_fail (tag > 0, FALSE); /* !!!!! */
source = g_main_context_find_source_by_id (NULL, tag);
if (source)
g_source_destroy (source);
return source != NULL;
}
Best Regards,
Junko Ikeda
NTT DATA INTELLILINK CORPORATION
<stderr.txt><ha-
log><GSource.patch>_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems
