Hi Dejan and All,

Thanks for your comments about apach RA.

And I think that there is a problem in the mysql RA.
My computer environment is as follows.

# mysql --version
mysql  Ver 14.12 Distrib 5.0.54a, for redhat-linux-gnu (x86_64) using  EditLine 
wrapper
#
# /usr/lib64/heartbeat/heartbeat -V
2.1.3
#

It seems that there is a problem about the following code in the
mysql_start function.

if [ $OCF_RESKEY_enable_creation -a ! -d $OCF_RESKEY_datadir/mysql] ;then
    ...
fi

Under the code above, if '! -d $OCF_RESKEY_datadir/mysql' is true,
the following behavior will be expected.

-> when "OCF_RESKEY_enable_creation=1",
   it will enter 'if' block.
-> when "OCF_RESKEY_enable_creation=0",
   it will enter 'if' block.
-> when "OCF_RESKEY_enable_creation" is not set in cib.xml,
   it will enter 'if' block.
-> when OCF_RESKEY_enable_creation="",
   syntax error will occur.
-> and when OCF_RESKEY_enable_creation="1 -eq 0",
   it won't enter 'if' block.

So I think in the current code, 'OCF_RESKEY_enable_creation' cannot be
judged clearly.
And if '! -d $OCF_RESKEY_datadir/mysql' is true, it will enter the 'if'
block, and initialize the DB.

Therefore, in my opinion some modification is necessary.
My idea is change the current code to following one:

if [ $OCF_RESKEY_enable_creation -eq 1 -a ! -d $OCF_RESKEY_datadir/mysql] ;then
    ...
fi

Which of 1 or 0 is better? I prefer '1'.
Because the default vaule of CF_RESKEY_enable_creation is '0'.

Please give me some comments.

Cheers,
Hiroshi

_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to