On Fri, Feb 29, 2008 at 12:13 PM, Alex Spengler <[EMAIL PROTECTED]> wrote:
>
> On 1/4/07, Andrew Beekhof <[EMAIL PROTECTED]> wrote:
>  >
>  > On 1/2/07, Andrew Beekhof <[EMAIL PROTECTED]> wrote:
>  > > On 1/1/07, Christian Froemmel <[EMAIL PROTECTED]> wrote:
>  > > > On Mon, 1 Jan 2007, Marian Neubert wrote:
>  > > >
>  > > > Hello,
>  > > >
>  > > > > crm_verify[11179]: 2007/01/01_12:13:26 ERROR:
>  > > > > ordinal_to_gregorian:iso8601.c Triggered non-fatal assert at
>  > > > > iso8601.c:618 : a_date->has->yeardays
>  > > >
>  > > > I found at least for this assert the error in the code.
>  > > >
>  > > > In file "lib/crm/common/iso8601.c" starting on line 827 there is a
>  > check
>  > > > for "rhs->tm_yday > 0":
>  > > >
>  > > >         if(rhs->tm_yday > 0) {
>  > > >                 /* days since January 1 [0-365] */
>  > > >                 lhs->yeardays = 1 + rhs->tm_yday;
>  > > >                 lhs->has->yeardays =TRUE;
>  > > >         }
>  > > >
>  > > > The comment inside the block is absolutely correct, so the first day
>  > of
>  > > > year is 0 in tm-structs - and the block is never executed on every new
>  > > > year of every year. I think it should read:
>  > > >
>  > > >         if(rhs->tm_yday >= 0) {
>  > > >                 /* days since January 1 [0-365] */
>  > > >                 lhs->yeardays = 1 + rhs->tm_yday;
>  > > >                 lhs->has->yeardays =TRUE;
>  > > >         }
>  > >
>  > > your assesment looks to be spot-on... i'll verify it with some testing
>  > > tomorrow and apply it asap
>  >
>  > pushed out as:
>  >   http://hg.beekhof.net/lha/crm-stable/rev/5c9c99904044
>
>
>
>  Hi,
>
>  may it be that a similar issue exists for the 29th. of february???

Lars fixed this while I was on vacation...
http://developerbugs.linux-foundation.org/show_bug.cgi?id=1849

>
>  [EMAIL PROTECTED] ~]# date -s "2008-02-27 12:09:00"
>  Wed Feb 27 12:09:00 CET 2008
>  [EMAIL PROTECTED] ~]# crm_verify -V -x /var/lib/heartbeat/crm/cib.xml
>  [EMAIL PROTECTED] ~]# date -s "2008-02-29 12:09:00"
>  Fri Feb 29 12:09:00 CET 2008
>  [EMAIL PROTECTED] ~]# crm_verify -V -x /var/lib/heartbeat/crm/cib.xml
>  crm_verify[2605]: 2008/02/29_12:09:01 ERROR: crm_abort: ha_set_tm_time:
>  Triggered assert at iso8601.c:879 : rhs->tm_mday < 0 || lhs->days ==
>  rhs->tm_mday
>  [EMAIL PROTECTED] ~]#
>
>  br,
>  alex
>
>
>
>  _______________________________________________
>  > Linux-HA mailing list
>  > [email protected]
>  > http://lists.linux-ha.org/mailman/listinfo/linux-ha
>  > See also: http://linux-ha.org/ReportingProblems
>  >
>  _______________________________________________
>  Linux-HA mailing list
>  [email protected]
>  http://lists.linux-ha.org/mailman/listinfo/linux-ha
>  See also: http://linux-ha.org/ReportingProblems
>
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to