Hi,
On Tue, Dec 09, 2008 at 04:54:30PM +0100, Tim Verhoeven wrote:
> Hi,
> 
> I'm using the IPaddr2 script in clone mode to manage a 2 node cluster
> that uses CLUSTERIP. But I think in this mode that the IPaddr2 script
> has a small bug, namely this :
> 
> # diff -u IPaddr2.orig IPaddr2
> --- IPaddr2.orig        2008-12-09 16:15:36.000000000 +0100
> +++ IPaddr2     2008-12-09 16:45:06.000000000 +0100
> @@ -596,6 +596,8 @@
>  }
> 
>  ip_start() {
> +       ip_init
> +
>         if [ -n "$IP_CIP" ]; then
>             # Cluster IPs need special processing when the first bucket
>             #  is added to the node... take a lock to make sure only one
> @@ -604,8 +606,6 @@
>             ocf_release_lock_on_exit $CIP_lockfile
>         fi
> 
> -       ip_init
> -
>         #
>         #       Do we already service this IP address?
>         #
> 
> I presume the ip_init needs to be called before the check if CLUSTERIP
> is being used and the locking is called. As it is in the ip_stop
> function.
> 
> I'm using version heartbeat-resources-2.99.2-6.1.

On RA review, it looked like the ip_init was not used in a
consistent manner, so a bit different patch, but to the same
effect has been applied.

Many thanks for reporing this.

Cheers,

Dejan

> Regards,
> Tim
> 
> -- 
> Tim Verhoeven - [EMAIL PROTECTED] - 0479 / 88 11 83
> 
> Hoping the problem  magically goes away  by ignoring it is the
> "microsoft approach to programming" and should never be allowed.
> (Linus Torvalds)
> _______________________________________________
> Linux-HA mailing list
> [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha
> See also: http://linux-ha.org/ReportingProblems
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to