On 02/23/2010 12:37 AM, Marian Marinov wrote: > Florian, > I greatly appreciate the comments. > > About the bash/sh. I prefer bash since I can use some neat things like REGEX > directly.
Yes, that's a bash 3 feature. Well I guess it's safe to assume that no one in their right mind will run an HA cluster on a box that comes with a pre-version-3 bash. > replication_aware - this was a first think I think of, thanks for the > suggestion already implemented > passwd/password - fixed > whitespaces - sorry but the script was not very well indented and I need it > indented in order to work. I'll try to clean this up for you. I understand > what is the problem you are facing. Now I realize that discussions about whitespace are among the most pointless in our industry, but please do stick to the indentation style the original author adopted. The current upstream release is indented just fine -- when viewed in Emacs, which the original author apparently used. :) > I keep my stuff in git, currently preparing all of my project to be published > with it. I have a mercurial clone of the agents. And I'll switch to it for > the > linux-ha projects, soon (hopefully by the middle of next week). Yes, please do. I'm fully with you in preferring git by default, and I use it for everything where the choice is mine, but linux-ha and pacemaker both use Mercurial so you'll have to go with that. If I can, you can too. :) It would also be helpful if you could break up your patch into easily digestible, logically self-contained chunks, such as - Low: RA: mysql: clean up whitespace (if you must) - Medium: RA: mysql: switch interpreter to bash - High: RA: mysql: introduce replication RA parameters (add parameters, defaults, metadata, and add relevant checks to the validate op) - High: RA: mysql: add promote and demote operations (add the functions themselves, and relevant changes to metadata, and the usage string) - High: RA: mysql: add notify operation (idem) Mercurial queues can come in quite handy for that. Just as a suggestion. And, please persist. :) We will eventually get this done. Cheers, Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Linux-HA mailing list [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
