On Thursday 18 November 2010 16:06:38 Matthew Richardson wrote: > I've been playing with the existing HealthSMART RA in Pacemaker and have > discovered a number of fundamental bugs and errors with it that mean it > will never have worked for anyone. > > I've done a big overhaul of this RA, replacing most of the logic to make > it work properly, and extending the component to cover a few more > use-cases: > > - Handles lists of drives > - Handles 'devices' behind drives - useful for RAID devices e.g 3ware, > megaraid etc > - Threshold for 'yellow' is now configurable (relative to upper/lower > limits) > - Various bugfixes, typos, indentation etc > > I've attached the whole RA to thsi email, as its changed enough that a > diff would have just been unhelpful. > > I'm fairly sure that the logic behind the smartctl result handling is > correct, I'm pretty sure the shell is all valid, but as I've been > working with an existing 'template' I can't guarantee that the > ocf-related bits are valid, as this is the area I know least about. > > I've tested it as much as I can, but I'd be grateful if other people > could review the code/test the RA and let me know if there are any > obvious bugs, errors or 'just plain bad code' in it :) > > Thanks, > > Matthew
good to hear! -- Dr. Michael Schwartzkopff Guardinistr. 63 81375 München Tel: (0163) 172 50 98
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Linux-HA mailing list [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
